-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolling to V8 12.6.228.3 #1466
Merged
Rolling to V8 12.6.228.3 #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72ee659
to
88c3f03
Compare
7fdfbcd
to
dca9f9f
Compare
2d18ca2
to
350a030
Compare
mmastrac
approved these changes
May 9, 2024
aeb310c
to
b28718e
Compare
75be72d
to
bc8a4ac
Compare
e7d16fd
to
434cc8e
Compare
434cc8e
to
6d54a25
Compare
6d54a25
to
aceb5f3
Compare
bartlomieju
reviewed
May 14, 2024
@@ -31,6 +31,8 @@ | |||
#include "v8/src/objects/objects.h" | |||
#include "v8/src/objects/smi.h" | |||
|
|||
#pragma clang diagnostic ignored "-Wdeprecated-declarations" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self, remove when #1478 is addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.