fix: Re-enable pointer compression #1473
Merged
+51
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
force-pushed
the
pointer_compression
branch
from
b5a39b3
to
3d11920
Compare
ry
approved these changes
May 15, 2024
tests/test_api.rs
Outdated
| let source = v8::String::new( | ||
| scope, | ||
| r#" | ||
| for(let i = 0; i < 1_000_000; i++) new ArrayBuffer(1024 * 1024); |
There was a problem hiding this comment.
Will drop it down by an order of magnitude which should still be sufficient
mmastrac
commented
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-land pointer compression now that @wingo's external pointer table GC changeset has landed.
Reverts #1302 / #1214