Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node compat test suite is failing on Windows #2807

Closed
cjihrig opened this issue Oct 24, 2022 · 1 comment · Fixed by denoland/deno#16417 or #2811
Closed

Node compat test suite is failing on Windows #2807

cjihrig opened this issue Oct 24, 2022 · 1 comment · Fixed by denoland/deno#16417 or #2811
Labels
bug Something isn't working needs triage

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Oct 24, 2022

Describe the bug

Starting with 820474d, the Windows CI has been failing consistently with the errors below. Nothing jumps out on the std side, so I'm thinking maybe it could be a change in core causing the failures here.

Node.js compatibility "parallel\test-net-allow-half-open.js" => ./node/_tools/test.ts:46:8
error: AssertionError: Failed assertion: error: Uncaught Error: read ECONNRESET
    Error.captureStackTrace(err);
          ^
    at __node_internal_captureLargerStackTrace (file:///C:/a/deno_std/deno_std/node/internal/errors.ts:113:11)
error: Test failed
    at __node_internal_errnoException (file:///C:/a/deno_std/deno_std/node/internal/errors.ts:194:10)
    at TCP.onStreamRead [as onread] (file:///C:/a/deno_std/deno_std/node/internal/stream_base_commons.ts:279:20)
    at TCP.#read (file:///C:/a/deno_std/deno_std/node/internal_binding/stream_wrap.ts:298:12)

    throw new AssertionError(msg);
          ^
    at assert (file:///C:/a/deno_std/deno_std/testing/asserts.ts:139:11)
    at fail (file:///C:/a/deno_std/deno_std/testing/asserts.ts:582:3)
    at fn (file:///C:/a/deno_std/deno_std/node/_tools/test.ts:92:9)

Node.js compatibility "parallel\test-net-socket-close-after-end.js" => ./node/_tools/test.ts:46:8
error: AssertionError: Failed assertion: error: Uncaught AssertionError
    Error.captureStackTrace(this, stackStartFn || stackStartFunction);
          ^
    at new AssertionError (file:///C:/a/deno_std/deno_std/node/assertion_error.ts:532:11)
    at toNode (file:///C:/a/deno_std/deno_std/node/assert.ts:77:15)
    at assert (file:///C:/a/deno_std/deno_std/node/assert.ts:95:3)
    at Socket.<anonymous> (file:///C:/a/deno_std/deno_std/node/_tools/test/parallel/test-net-socket-close-after-end.js:28:5)
    at Socket.emit (file:///C:/a/deno_std/deno_std/node/_events.mjs:379:28)
    at file:///C:/a/deno_std/deno_std/node/net.ts:1424:14
    at deno:core/01_core.js:236:9

    throw new AssertionError(msg);
          ^
    at assert (file:///C:/a/deno_std/deno_std/testing/asserts.ts:139:11)
    at fail (file:///C:/a/deno_std/deno_std/testing/asserts.ts:582:3)
    at fn (file:///C:/a/deno_std/deno_std/node/_tools/test.ts:92:9)

 FAILURES 

Node.js compatibility "parallel\test-net-allow-half-open.js" => ./node/_tools/test.ts:46:8
Node.js compatibility "parallel\test-net-socket-close-after-end.js" => ./node/_tools/test.ts:46:8

Environment
CI. I don't have a Windows setup to test locally.

@cjihrig cjihrig added bug Something isn't working needs triage labels Oct 24, 2022
@bartlomieju
Copy link
Member

I suspect it might be related to denoland/deno@c061538 I got some unexpected network errors in another context. CC @lucacasonato I think we should revert that change and revist after v1.27 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
2 participants