refactor(ext/net): clean up variadic network ops #16392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
clean_up_ext_net
branch
5 times, most recently
from
aaf8a3b
to
53c2761
Compare
Previously `op_net_listen`, `op_net_accept`, and various other ops in ext/net where variadic on the transport. This created a lot of code bloat. This commit updates the code to instead have separate ops for each transport.
lucacasonato
force-pushed
the
clean_up_ext_net
branch
from
53c2761
to
1fb8b1e
Compare
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Oct 25, 2022
)" This reverts commit c061538.
bartlomieju
added a commit
that referenced
this pull request
Oct 25, 2022
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Oct 25, 2022
…oland#16392)" (denoland#16417)" This reverts commit 8e3f825.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
op_net_listen,op_net_accept, and various other ops in ext/net where variadic on the transport. This created a lot of code bloat. This commit updates the code to instead have separate ops for each transport.