Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inlay hints #509

Closed
kitsonk opened this issue Aug 26, 2021 · 10 comments
Closed

Support inlay hints #509

kitsonk opened this issue Aug 26, 2021 · 10 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Aug 26, 2021

TypeScript 4.4 which will be in Deno 1.14 supports inlay hints: https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#inlay-hints

We need to plumb that through in the LSP and integrate it into the extension.

@kitsonk kitsonk added the enhancement New feature or request label Aug 26, 2021
@kitsonk
Copy link
Contributor Author

kitsonk commented Aug 30, 2021

Sadly, InlayHints are "experimental" in vscode at the moment, and there is no way to publish an extension that uses them, until the APIs are moved to stable. Even then, they are currently not part of the language server protocol. That isn't specifically a limitation as we can likely add the feature as a custom extension until it gets added.

@kitsonk
Copy link
Contributor Author

kitsonk commented Sep 3, 2021

Now vscode has shipped, but the API is still proposed, meaning we can't publish an extension that uses it.

Issue requesting it be made available to other extension authors: microsoft/vscode#132197
There was an already existing issue to add it to the language server protocol, though it doesn't look like there was any movement of adding the vscode implementation to the specification ATM: microsoft/language-server-protocol#956

@ghost
Copy link

ghost commented Oct 22, 2021

I have been using inlay hints in vscode for node projects and it's really useful. Any plans on supporting this is deno?

@kitsonk
Copy link
Contributor Author

kitsonk commented Oct 22, 2021

It is blocked by it being added to the LSP specification.

@MihaelBercic
Copy link

It is blocked by it being added to the LSP specification.

What is the solution to be able to use inlay hints with deno in the end?

@sno2
Copy link

sno2 commented Mar 20, 2022

The next LSP specification version will include inlay hints.

@kitsonk
Copy link
Contributor Author

kitsonk commented Mar 20, 2022

The new APIs need to be added to lsp-types and then the changes need to be integrated into lspower. Once that is done, it should be possible to make them available in the lsp. I would get around to doing that eventually, but it is a good opportunity for community contribution, and fairly straight forward changes. Also contributions to lsp-types and lspower benefit a lot of Rust community language server implementations, not just Deno.

@kitsonk kitsonk added the help wanted Extra attention is needed label Mar 20, 2022
@sno2
Copy link

sno2 commented Mar 21, 2022

@kitsonk It seems that lspower is now deprecated as of 12 days ago in favor of tower-lsp FYI

@kitsonk
Copy link
Contributor Author

kitsonk commented Mar 21, 2022

ah, ok... I should have paid closer attention... anyways, it needs to be integrated into tower-lsp then!

@kitsonk
Copy link
Contributor Author

kitsonk commented Oct 27, 2022

Closed by denoland/deno#16287, #739 and #740

@kitsonk kitsonk closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants