Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support inlay hints #16287

Merged
merged 3 commits into from
Oct 16, 2022
Merged

feat: support inlay hints #16287

merged 3 commits into from
Oct 16, 2022

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Oct 15, 2022

Closes: #11853

Tests are still required.

The settings, if you want to manually set them, that impact the behaviour are:

  • "deno.inlayHints.parameterNames.enabled" ("none", "literals", "all")
  • "deno.inlayHints.parameterNames.suppressWhenArgumentMatchesName" (boolean)
  • "deno.inlayHints.parameterTypes.enabled" (boolean)
  • "deno.inlayHints.variableTypes.enabled" (boolean)
  • "deno.inlayHints.variableTypes.suppressWhenTypeMatchesName" (boolean)
  • "deno.inlayHints.propertyDeclarationTypes.enabled" (boolean)
  • "deno.inlayHints.functionLikeReturnTypes.enabled" (boolean)
  • "deno.inlayHints.enumMemberValues.enabled" (boolean)

@kitsonk kitsonk changed the title feat: support inlay hints [WIP] feat: support inlay hints Oct 15, 2022
@kitsonk kitsonk marked this pull request as ready for review October 15, 2022 13:15
@kitsonk kitsonk changed the title [WIP] feat: support inlay hints feat: support inlay hints Oct 15, 2022
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju added this to the 1.27 milestone Oct 15, 2022
@kitsonk kitsonk merged commit 7d78f58 into denoland:main Oct 16, 2022
@kitsonk kitsonk deleted the feat_inlay_hints branch October 16, 2022 02:39
kitsonk added a commit to denoland/vscode_deno that referenced this pull request Oct 16, 2022
fannheyward referenced this pull request in fannheyward/coc-deno Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lsp: support inlay hints
3 participants