Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: migrate from lspower back to tower-lsp #14056

Closed
kitsonk opened this issue Mar 21, 2022 · 7 comments · Fixed by #14163
Closed

lsp: migrate from lspower back to tower-lsp #14056

kitsonk opened this issue Mar 21, 2022 · 7 comments · Fixed by #14163
Labels
lsp related to the language server refactor

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Mar 21, 2022

lspower was a fork that fixed a lot of things with tower-lsp, but not lspower has been remerged back into tower-lsp and deprecated. tower-lsp is being maintained going forward, so we should/need to remigrate back.

@kitsonk kitsonk added refactor lsp related to the language server labels Mar 21, 2022
@kitsonk
Copy link
Contributor Author

kitsonk commented Mar 21, 2022

(thanks @sno2 for pointing it out)

@AbhijithGanesh
Copy link

is this a good first issue for a new contributor?

@kitsonk
Copy link
Contributor Author

kitsonk commented Mar 21, 2022

Not entirely sure... It could be very straight forward, but it could get quite tricky if it doesn't work. If someone were to try to do it and the tests didn't pass, it could get quite complicated to figure out, but would be glad to try to help if someone wanted to try.

@AbhijithGanesh
Copy link

Does this have a pre-commit script with which I can locally test the changes? I am up for trying it and I can reach out on discord if I have doubts. Would that work?

@AbhijithGanesh
Copy link

@CGQAQ If I want to add in my changes, can I push it to your PR?

@CGQAQ
Copy link
Contributor

CGQAQ commented Mar 21, 2022

@AbhijithGanesh Sorry but I am almost done the refactoring, just lack of tests fix 😢

@AbhijithGanesh
Copy link

No issues , just wanted to know. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lsp related to the language server refactor
Projects
None yet
3 participants