feat: make --inspect-wait default when debugging
#775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bartlomieju
reviewed
Dec 27, 2022
bartlomieju
pushed a commit
that referenced
this pull request
Aug 25, 2023
# Motivation vscode_deno offers a code lens action "Run Test | Debug". However when clicking the "Debug", it triggers a breakpoint which an user did not set. # Changes made Unified the logic for selecting the appropriate debugging flag (--inspect-brk or --inspect-wait) based on the behavior of pull request feat: make --inspect-wait default when debugging #775.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #774 and possibly makes #608 obsolete.
Please let me know if I should change or test something specific. I've tested with current and old Deno versions.
I had to change the argument received in the constructor because I needed to check the version of the Deno Server.
From what I observed (code below),
getSettings === extensionContext.clientOptions.initializationOptions, so I adjusted the calls.vscode_deno/client/src/extension.ts
Line 198 in 5ab30d8
vscode_deno/client/src/extension.ts
Line 245 in 5ab30d8