fix: NULL pointer not being recognized #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bug that slipped in #25
The function
maybeThrowError()
saves errors codes in a array ofBigUInt64Array
. This automatically converts the pointers intobigint
. I had modified theget isNone()
function to only check fornumber
. Some errors were ignored because of this.I added 2 tests to check error handling.
Might be a good idea to create a util function
isZero()
that handles bothnumber
andbigint
.