Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw error if --unstable isn't provided #28

Merged
merged 2 commits into from
Dec 25, 2022
Merged

fix: throw error if --unstable isn't provided #28

merged 2 commits into from
Dec 25, 2022

Conversation

lino-levan
Copy link
Contributor

This was a minor headache to debug because the try-catch swallowed this error.

Hoping this will help others in case they don't read the README carefully enough.

@lino-levan
Copy link
Contributor Author

Pretty sure these test failures aren't from this change but would like some confirmation.

DjDeveloperr
DjDeveloperr approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@DjDeveloperr DjDeveloperr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DjDeveloperr DjDeveloperr merged commit 1aa6036 into denosaurs:main Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DjDeveloperr DjDeveloperr DjDeveloperr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lino-levan @DjDeveloperr