Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Rename/Code Actions more intuitive #3332

Closed
w0rp opened this issue Sep 3, 2020 · 2 comments
Closed

Make Rename/Code Actions more intuitive #3332

w0rp opened this issue Sep 3, 2020 · 2 comments
Assignees
@w0rp
Labels
enhancement LSP Any issue relating to LSP or tsserver
Projects
On the Radar

Comments

@w0rp
Copy link
Member

w0rp commented Sep 3, 2020

Whenever you apply changes with :ALERename, and in future with code actions, ALE does two things that can be improved on in important ways.

  1. If a file needs to be saved first before applying changes, ALE will mention that a file needs to be saved, but it won't tell you which ones. ALE should print which files you should save first.
  2. If ALE changes a buffer that is hidden, the buffer may not be updated until you use say :e!. ALE should force buffers that are modified to reload.
@w0rp w0rp added enhancement LSP Any issue relating to LSP or tsserver labels Sep 3, 2020
@w0rp w0rp added this to To Do in On the Radar via automation Sep 3, 2020
@w0rp w0rp self-assigned this Sep 3, 2020
@w0rp w0rp moved this from To Do to In Progress in On the Radar Oct 15, 2020
w0rp added a commit that referenced this issue Oct 15, 2020
@w0rp
#3332 Implement :ALERename! for ignoring errors
477eb89 
:ALERename! now ignores errors for files that cannot be modified, and
modifies all other files.
@w0rp
Copy link
Member Author

w0rp commented Oct 15, 2020

This wasn't in the list above, but I added bang support so you can run :ALERename! and ignore all of the errors about files that cannot be modified, and just modify all of the other files instead.

@w0rp w0rp closed this as completed in 06e7f21 Nov 21, 2020
On the Radar automation moved this from In Progress to Done Nov 21, 2020
@w0rp
Copy link
Member Author

w0rp commented Nov 21, 2020

I've removed the bang (!) for :ALERename, and now it just modifies other buffers and reloads them when you next enter them (BufEnter) automatically. This makes renaming just work without you needing to think about what it's doing. This is good behaviour because files that aren't open in Vim will already be modified, this just makes the behaviour consistent between files you have open in Vim already or not.

ivorpeles pushed a commit to ivorpeles/ale that referenced this issue Nov 22, 2020
@w0rp @ivorpeles
dense-analysis#3332 Implement :ALERename! for ignoring errors
3f6c91f 
:ALERename! now ignores errors for files that cannot be modified, and
modifies all other files.
ivorpeles pushed a commit to ivorpeles/ale that referenced this issue Nov 22, 2020
@w0rp @ivorpeles
Fix dense-analysis#3332 - Modify everything for rename/actions
db28a6d 
ALE now just modifies every open buffer for rename and actions, and sets
up a one-time use BufEnter event to reload buffers that are changed so
you don't have to think about what to do with changed buffers.
benknoble added a commit to benknoble/ale that referenced this issue Nov 30, 2020
@benknoble
Merge remote-tracking branch 'origin/master' into fix-swipl
7e12be0 
* origin/master: (40 commits)
  fix: correct suggested filetype for yamlfix
  feat: add yamlfix fixer
  Use _config for LSP config options
  Add support for R languageserver (dense-analysis#3370)
  Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216)
  Added the Vundle command in installation instructions (dense-analysis#3400)
  Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291)
  Add php phpcbf options (dense-analysis#3383)
  Use has('gui_running') instead of has('gui')
  Close dense-analysis#2727 - Add a hover-only setting for balloons
  Fix dense-analysis#3332 - Modify everything for rename/actions
  Add a missing blank line in documentation
  Add luafmt fixer (dense-analysis#3289)
  dense-analysis#3442 Fix code fix clangd issue
  Close dense-analysis#1466 - Add GVIM refactor menu support
  Look for node packages in .yarn/sdks as well
  Update documentation for code actions and rename
  cmp forwards, and reverse the code actions
  Support for LSP/tsserver Code Actions (dense-analysis#3437)
  Move the test for buffer-local variables
  ...
jsit added a commit to jsit/ale that referenced this issue Dec 26, 2020
@jsit
Merge remote-tracking branch 'origin/master' into jsit-master
50214cf 
* origin/master: (164 commits)
  fix: correct suggested filetype for yamlfix
  feat: add yamlfix fixer
  Use _config for LSP config options
  Add support for R languageserver (dense-analysis#3370)
  Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216)
  Added the Vundle command in installation instructions (dense-analysis#3400)
  Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291)
  Add php phpcbf options (dense-analysis#3383)
  Use has('gui_running') instead of has('gui')
  Close dense-analysis#2727 - Add a hover-only setting for balloons
  Fix dense-analysis#3332 - Modify everything for rename/actions
  Add a missing blank line in documentation
  Add luafmt fixer (dense-analysis#3289)
  dense-analysis#3442 Fix code fix clangd issue
  Close dense-analysis#1466 - Add GVIM refactor menu support
  Look for node packages in .yarn/sdks as well
  Update documentation for code actions and rename
  cmp forwards, and reverse the code actions
  Support for LSP/tsserver Code Actions (dense-analysis#3437)
  Move the test for buffer-local variables
  ...
motato1 pushed a commit to motato1/ale that referenced this issue Jan 11, 2021
@w0rp @motato1
dense-analysis#3332 Implement :ALERename! for ignoring errors
37a353f 
:ALERename! now ignores errors for files that cannot be modified, and
modifies all other files.
motato1 pushed a commit to motato1/ale that referenced this issue Jan 11, 2021
@w0rp @motato1
Fix dense-analysis#3332 - Modify everything for rename/actions
9340a35 
ALE now just modifies every open buffer for rename and actions, and sets
up a one-time use BufEnter event to reload buffers that are changed so
you don't have to think about what to do with changed buffers.
jsit added a commit to jsit/ale that referenced this issue Apr 19, 2021
@jsit
Merge remote-tracking branch 'origin/master' into fix-3271
ceaed92 
* origin/master:
  Move the test for buffer-local variables
  Use the proper term for the "#!" line
  Remove a noise comment
  Make the two nearly identical Swift tools easier to distinguish
  dense-analysis#3332 Implement :ALERename! for ignoring errors
  Fix sorting of supported tools
jsit added a commit to jsit/ale that referenced this issue Apr 19, 2021
@jsit
Merge branch 'master' into fix-3271
fb1510b 
* master: (35 commits)
  fix: correct suggested filetype for yamlfix
  feat: add yamlfix fixer
  Use _config for LSP config options
  Add support for R languageserver (dense-analysis#3370)
  Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216)
  Added the Vundle command in installation instructions (dense-analysis#3400)
  Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291)
  Add php phpcbf options (dense-analysis#3383)
  Use has('gui_running') instead of has('gui')
  Close dense-analysis#2727 - Add a hover-only setting for balloons
  Fix dense-analysis#3332 - Modify everything for rename/actions
  Add a missing blank line in documentation
  Add luafmt fixer (dense-analysis#3289)
  dense-analysis#3442 Fix code fix clangd issue
  Close dense-analysis#1466 - Add GVIM refactor menu support
  Look for node packages in .yarn/sdks as well
  Update documentation for code actions and rename
  cmp forwards, and reverse the code actions
  Support for LSP/tsserver Code Actions (dense-analysis#3437)
  feat: add autoimport fixer
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w0rp w0rp

Labels
enhancement LSP Any issue relating to LSP or tsserver
Projects
On the Radar
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@w0rp