Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for R languageserver #3370

Merged
merged 13 commits into from
Nov 21, 2020
Merged

Conversation

mirryi
Copy link
Contributor

@mirryi mirryi commented Sep 26, 2020

Resolves #3048 .

This PR adds support for languageserver, the language server implementation for R.

@stale
Copy link

stale bot commented Oct 24, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Oct 24, 2020
@mirryi
Copy link
Contributor Author

mirryi commented Oct 24, 2020

@w0rp Do you mind merging this?

@stale stale bot removed the stale PRs a bot will close automatically label Oct 24, 2020
@mutlusun
Copy link

Hello,
thanks for your work @Dophin2009 ! I tested this branch with neovim 0.4.3 and the languageserver implementation works as expected. Thank you!

Best

" Description: Implementation of the Language Server Protocol for R.

call ale#Set('r_languageserver_cmd', 'languageserver::run()')
call ale#Set('r_languageserver_options', {})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rename the option to _config. I like to use _config for LSP configuration, and _options for command line options.

@w0rp w0rp merged commit 9692c0c into dense-analysis:master Nov 21, 2020
ivorpeles pushed a commit to ivorpeles/ale that referenced this pull request Nov 22, 2020
benknoble added a commit to benknoble/ale that referenced this pull request Nov 30, 2020
* origin/master: (40 commits)
  fix: correct suggested filetype for yamlfix
  feat: add yamlfix fixer
  Use _config for LSP config options
  Add support for R languageserver (dense-analysis#3370)
  Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216)
  Added the Vundle command in installation instructions (dense-analysis#3400)
  Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291)
  Add php phpcbf options (dense-analysis#3383)
  Use has('gui_running') instead of has('gui')
  Close dense-analysis#2727 - Add a hover-only setting for balloons
  Fix dense-analysis#3332 - Modify everything for rename/actions
  Add a missing blank line in documentation
  Add luafmt fixer (dense-analysis#3289)
  dense-analysis#3442 Fix code fix clangd issue
  Close dense-analysis#1466 - Add GVIM refactor menu support
  Look for node packages in .yarn/sdks as well
  Update documentation for code actions and rename
  cmp forwards, and reverse the code actions
  Support for LSP/tsserver Code Actions (dense-analysis#3437)
  Move the test for buffer-local variables
  ...
@zoj613
Copy link

zoj613 commented Dec 2, 2020

Thanks for this @Dophin2009 . I was just today looking to see if ALE supports R language server.

jsit added a commit to jsit/ale that referenced this pull request Dec 26, 2020
* origin/master: (164 commits)
  fix: correct suggested filetype for yamlfix
  feat: add yamlfix fixer
  Use _config for LSP config options
  Add support for R languageserver (dense-analysis#3370)
  Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216)
  Added the Vundle command in installation instructions (dense-analysis#3400)
  Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291)
  Add php phpcbf options (dense-analysis#3383)
  Use has('gui_running') instead of has('gui')
  Close dense-analysis#2727 - Add a hover-only setting for balloons
  Fix dense-analysis#3332 - Modify everything for rename/actions
  Add a missing blank line in documentation
  Add luafmt fixer (dense-analysis#3289)
  dense-analysis#3442 Fix code fix clangd issue
  Close dense-analysis#1466 - Add GVIM refactor menu support
  Look for node packages in .yarn/sdks as well
  Update documentation for code actions and rename
  cmp forwards, and reverse the code actions
  Support for LSP/tsserver Code Actions (dense-analysis#3437)
  Move the test for buffer-local variables
  ...
motato1 pushed a commit to motato1/ale that referenced this pull request Jan 11, 2021
jsit added a commit to jsit/ale that referenced this pull request Apr 19, 2021
* master: (35 commits)
  fix: correct suggested filetype for yamlfix
  feat: add yamlfix fixer
  Use _config for LSP config options
  Add support for R languageserver (dense-analysis#3370)
  Fix 3103 - add shellcheck shell directive detection. (dense-analysis#3216)
  Added the Vundle command in installation instructions (dense-analysis#3400)
  Adds support for Tlint - A Tighten Opinionated PHP Linter (dense-analysis#3291)
  Add php phpcbf options (dense-analysis#3383)
  Use has('gui_running') instead of has('gui')
  Close dense-analysis#2727 - Add a hover-only setting for balloons
  Fix dense-analysis#3332 - Modify everything for rename/actions
  Add a missing blank line in documentation
  Add luafmt fixer (dense-analysis#3289)
  dense-analysis#3442 Fix code fix clangd issue
  Close dense-analysis#1466 - Add GVIM refactor menu support
  Look for node packages in .yarn/sdks as well
  Update documentation for code actions and rename
  cmp forwards, and reverse the code actions
  Support for LSP/tsserver Code Actions (dense-analysis#3437)
  feat: add autoimport fixer
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support R languageserver
4 participants