Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numhl highlights for vim isn't supported by ALE #4579

Closed
alt-romes opened this issue Aug 3, 2023 · 0 comments · Fixed by #4578
Closed

numhl highlights for vim isn't supported by ALE #4579

alt-romes opened this issue Aug 3, 2023 · 0 comments · Fixed by #4578
Labels
bug

Comments

@alt-romes
Copy link
Contributor

In #2637, support for numhl highlights was added for nvim.

In the meantime, vim added support for numhl highlights in patch 8.2.3874.

However, ALE still doesn't allow numhl highlights to be enabled in vim.

Fix in #4578.
@alt-romes alt-romes added the bug label Aug 3, 2023
@alt-romes alt-romes mentioned this issue Aug 3, 2023
Merged
@w0rp w0rp closed this as completed in #4578 Aug 5, 2023
w0rp pushed a commit that referenced this issue Aug 5, 2023
@alt-romes
Close #4579 - Support numhl highlights for vim >= 8.2.3874
15cbc0e 
In #2637, support for numhl highlights was added for nvim.

In the meantime, vim added support for numhl highlights in patch 8.2.3874.

This patch allows numhl highlights to be enabled in ALE for vim >= 8.2.3874 too.
mnikulin pushed a commit to mnikulin/ale that referenced this issue Nov 12, 2023
@alt-romes @mnikulin
Close dense-analysis#4579 - Support numhl highlights for vim >= 8.2.3874
4838ff0 
In dense-analysis#2637, support for numhl highlights was added for nvim.

In the meantime, vim added support for numhl highlights in patch 8.2.3874.

This patch allows numhl highlights to be enabled in ALE for vim >= 8.2.3874 too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support numhl highlights for vim >= 8.2.3874 alt-romes/ale
1 participant
@alt-romes