Add setting for numhl highlights #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be good to change each highlight in relation to sign's one. But the default highlights should have links to
" these setting are used in the screenshot above.
hi ALEErrorSignLineNr guifg=#bf616a guibg=#52050c gui=bold
hi ALEStyleErrorSignLineNr guifg=#bf616a guibg=#52050c gui=bold
hi ALEWarningSignLineNr guifg=#ebcb8b guibg=#432d00 gui=bold
hi ALEStyleWarningSignLineNr guifg=#ebcb8b guibg=#432d00 gui=bold
hi ALEInfoSignLineNr guifg=#a3be8c guibg=#163601 gui=bold |
|
Fixed. Please review this @w0rp |
w0rp
approved these changes
Jul 29, 2019
|
How can I disable this feature if I don't want the line numbers to be highlighted (bold) ? |
|
Some more details: With Before this commit
After this commitBoth If I set "hi link ALEErrorSignLineNr LineNr"Neither There's not way to get the original behavior. Can we please have a setting for this change? |
|
If other's are interested, have a look at @blahgeek's PR. I'll try to get a modified version of that merged soon. |
suoto
pushed a commit
to suoto/ale
that referenced
this pull request
Sep 11, 2019
* Add setting for numhl highlights * Add doc for numhl feature
timlag1305
pushed a commit
to timlag1305/ale
that referenced
this pull request
Nov 5, 2019
* Add setting for numhl highlights * Add doc for numhl feature
alt-romes
added a commit
to alt-romes/ale
that referenced
this pull request
Aug 3, 2023
In dense-analysis#2637, support for numhl highlights was added for nvim. In the meantime, vim added support for numhl highlights in patch 8.2.3874. This patch allows numhl highlights to be enabled in ALE for vim >= 8.2.3874 too.
alt-romes
added a commit
to alt-romes/ale
that referenced
this pull request
Aug 3, 2023
In dense-analysis#2637, support for numhl highlights was added for nvim. In the meantime, vim added support for numhl highlights in patch 8.2.3874. This patch allows numhl highlights to be enabled in ALE for vim >= 8.2.3874 too.
This was referenced Aug 3, 2023
w0rp
pushed a commit
that referenced
this pull request
Aug 5, 2023
In #2637, support for numhl highlights was added for nvim. In the meantime, vim added support for numhl highlights in patch 8.2.3874. This patch allows numhl highlights to be enabled in ALE for vim >= 8.2.3874 too.
mnikulin
pushed a commit
to mnikulin/ale
that referenced
this pull request
Nov 12, 2023
In dense-analysis#2637, support for numhl highlights was added for nvim. In the meantime, vim added support for numhl highlights in patch 8.2.3874. This patch allows numhl highlights to be enabled in ALE for vim >= 8.2.3874 too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neovim has
numhloption for signs. This PR adds highlights for this.neovim/neovim@bddcbbb
related: airblade/vim-gitgutter#632
ALE(Error|StyleError|Warning|StyleWarning|Info)LineNr.CursorLineNr.TODO
I will adds these later!