-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around hot-reloading issue #1266
Conversation
ale_linters/elixir/credo.vim
Outdated
@@ -32,6 +32,6 @@ endfunction | |||
call ale#linter#Define('elixir', { | |||
\ 'name': 'credo', | |||
\ 'executable': 'mix', | |||
\ 'command': 'mix credo suggest --format=flycheck --read-from-stdin %s', | |||
\ 'command': 'MIX_ENV=lint mix credo suggest --format=flycheck --read-from-stdin %s', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For windows, this will need to be set MIX_ENV=lint && ...
Look at say ale_linters/slim/slimlint.vim
for an example of setting environment variables for all supported platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @w0rp . But I'll need more time to incorporate that and test it on windows. Feel free to close this PR if you'd like to. I can open another one when it's ready.
See phoenixframework/phoenix#1165 for more detail
Hi @w0rp - Would you mind reviewing this again? I've just rebased and merged my latest commit because the first commit caused other issue, and I have to take another approach and it turns out that approach doesn't have to rely on setting environment variables. Since the intermediate approach doesn't work, I just removed that commit. Hope you don't mind. Thanks a million. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works, it works. Let's try it and see what other users say.
Cheers! 🍻 |
See phoenixframework/phoenix#1165 for more detail
This change is