Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around hot-reloading issue #1266

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Work around hot-reloading issue #1266

merged 1 commit into from
Jan 19, 2018

Conversation

sharils
Copy link
Contributor

@sharils sharils commented Jan 6, 2018

See phoenixframework/phoenix#1165 for more detail


This change is Reviewable

@@ -32,6 +32,6 @@ endfunction
call ale#linter#Define('elixir', {
\ 'name': 'credo',
\ 'executable': 'mix',
\ 'command': 'mix credo suggest --format=flycheck --read-from-stdin %s',
\ 'command': 'MIX_ENV=lint mix credo suggest --format=flycheck --read-from-stdin %s',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For windows, this will need to be set MIX_ENV=lint && ... Look at say ale_linters/slim/slimlint.vim for an example of setting environment variables for all supported platforms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @w0rp . But I'll need more time to incorporate that and test it on windows. Feel free to close this PR if you'd like to. I can open another one when it's ready.

@sharils
Copy link
Contributor Author

sharils commented Jan 10, 2018

Hi @w0rp - Would you mind reviewing this again? I've just rebased and merged my latest commit because the first commit caused other issue, and I have to take another approach and it turns out that approach doesn't have to rely on setting environment variables. Since the intermediate approach doesn't work, I just removed that commit. Hope you don't mind. Thanks a million.

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works. Let's try it and see what other users say.

@w0rp w0rp merged commit 1d3b542 into dense-analysis:master Jan 19, 2018
@w0rp
Copy link
Member

w0rp commented Jan 19, 2018

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants