Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lsp] Add Swift / SourceKit-LSP support #2420

Merged

Conversation

namolnad
Copy link
Contributor

@namolnad namolnad commented Apr 5, 2019

Swift LSP Support

This adds LSP support for Swift via the recently announced/open-source SourceKit-LSP.

Addresses #2147 (Thanks @TaDaa for the initial work on the fork — this is based on your original work.)

Tasks:

  • Add LSP support for Swift via SourceKit-LSP
  • Add tests

@namolnad namolnad marked this pull request as ready for review April 6, 2019 16:39
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in a test for the linter executable and command. Then we can test that the linter will be loaded okay. See :help ale-tests and look at some existing tests for examples. Otherwise, this looks pretty good to me. 👍

@w0rp w0rp added this to In Review in Old Working List via automation Apr 8, 2019
@namolnad
Copy link
Contributor Author

namolnad commented Apr 8, 2019

Thanks for the feedback @w0rp! I updated with some additional tests based off some existing examples.

(Coincidentally after trying to run :help ale-tests I also realized I needed to generate help tags for my plugins and used your example in the main README to do that — so thanks for that as well!)

@w0rp w0rp merged commit 864d086 into dense-analysis:master Apr 8, 2019
Old Working List automation moved this from In Review to Done Apr 8, 2019
@w0rp
Copy link
Member

w0rp commented Apr 8, 2019

Cheers! 🍻

@w0rp
Copy link
Member

w0rp commented Apr 8, 2019

One thing I forgot, which you can add now, is add the new linter to the list of supported tools in Markdown and in the Vim help file.

@namolnad namolnad deleted the namolnad_lsp_sourcekit-lsp-support branch April 8, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants