Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add g:ale_sign_highlight_linenr #2678

Merged
merged 4 commits into from
Sep 1, 2019
Merged

Add g:ale_sign_highlight_linenr #2678

merged 4 commits into from
Sep 1, 2019

Conversation

blahgeek
Copy link
Contributor

@blahgeek blahgeek commented Aug 4, 2019 •
edited by w0rp
Loading

@bluz71 bluz71 mentioned this pull request Aug 6, 2019
Closed
w0rp
w0rp requested changes Sep 1, 2019
View reviewed changes
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the feedback in #2680. I think the suggestions there are sensible. Make the default setting 0, and use the liners name mentioned there. If this new feature can cause the issues, then it's worth leaving it off by default.

@w0rp w0rp added this to In Review in On the Radar via automation Sep 1, 2019
@blahgeek
Copy link
Contributor Author

blahgeek commented Sep 1, 2019

🍺

@w0rp w0rp merged commit 9f814a8 into dense-analysis:master Sep 1, 2019
On the Radar automation moved this from In Review to Done Sep 1, 2019
@w0rp
Copy link
Member

w0rp commented Sep 1, 2019

Cheers! 🍻

suoto pushed a commit to suoto/ale that referenced this pull request Sep 11, 2019
@blahgeek
Add g:ale_sign_highlight_linenr (dense-analysis#2678)
52e9dc1 
* add g:ale_sign_highlight_linenr
* Fix tests. Change option default value
* Rename ale_sign_highlight_linenr to ale_sign_highlight_linenrs
* Default ale_sign_highlight_linenrs to 0
timlag1305 pushed a commit to timlag1305/ale that referenced this pull request Nov 5, 2019
@blahgeek @timlag1305
Add g:ale_sign_highlight_linenr (dense-analysis#2678)
71288cc 
* add g:ale_sign_highlight_linenr
* Fix tests. Change option default value
* Rename ale_sign_highlight_linenr to ale_sign_highlight_linenrs
* Default ale_sign_highlight_linenrs to 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rp w0rp w0rp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
On the Radar
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add option 'g:ale_highlight_linenrs' (default to 0) to control 'numhl'-based highlighting
2 participants
@blahgeek @w0rp