Add dart analysis server to linter

[nelsyeung]

Add Dart analysis_server to linter. Closes #1005

[RRethy]

I've been using it locally and it's working well for me.

[bluz71]

I just tested this PR locally.

Functionally it works great.

However, I am receiving the following noise in the command line area:

Unknown method textDocument/didSave

This appears every time I hit save, which is my trigger for a lint to occur.

I am using Flutter v1.12.13+hotfix.8.

It would be highly desirable to silently consume this particular message, it gets annoying fast.

Best regards.

[RRethy]

I'm also seeing that, part of my config was hiding it so I didn't notice previously.

[RRethy]

sublimelsp/LSP#550 this issue describes it.

[bluz71]

I'm also seeing that, part of my config was hiding it so I didn't notice previously.

How did you hide it? This PR probably should probably include that workaround.

[RRethy]

It's not applicable, it was being hidden because I was echoing a bunch of other messages. It would still show up in :messages but with other messages so I didn't notice it.

[bluz71]

These issues are relevant:

• LSP: Unknown method textDocument/didSave

• Don't send textDocument/didSave unless server advertises support for it

Correct me if I am wrong, but I think ALE may be sending textDocument/didSave to the Dart Analysis Server even after the server says it doesn't support textDocumentSync > save.

I suspect ALE LSP code needs to be refined to not send textDocument/didSave after the server initially indicates it doesn't support that operation.

As it stands at the moment, every Dart file save is triggering this alert which distracts from genuine lint messages.

[nelsyeung]

@bluz71 Do you think it's worth raising this as a separate issue and create a fix in a separate PR?

[bluz71]

Yes, it is a separate issue. It should not hold this up.

I was going to create a new issue today, but got distracted with other stuff. I will do so soon.

[bluz71]

New issue, #3207, spawned about the didSave issue.

This PR can be merged independent of that. This looks ready now.

[stale]

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

[nelsyeung]

@w0rp This is certainly not stale and would love to be merged asap.

[bluz71]

Seconded. Looking forward to seeing this merged.

[stale]

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

[nelsyeung]

@w0rp bump

[bluz71]

I agree, not stale.

[stale]

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

[nelsyeung]

I'm not gonna lose this battle to a bot!

[lukaszo]

Hello @nelsyeung

please consider updating your patch with this tiny patch:

11c11
<     return !empty(l:pubspec) ? fnamemodify(l:pubspec, ':h:h') : ''
---
>     return !empty(l:pubspec) ? fnamemodify(l:pubspec, ':h:h') : '.'

I've just changed it to return current dir when pubspec is not available. In this way it will support also standalone files.

[matsp]

Anything missing? Out of the box support would be really great 👍

[nelsyeung]

Anything missing? Out of the box support would be really great 👍

Nope, just waiting for review and merge.

[matsp]

@hwasoocho Can you please review this PR?

[matsp]

@RRethy @guildem Can someone else review this PR?

[hsanson]

Missing tests. Check the test/command_callbak folder for examples on how to write tests for command callbacks.

[nelsyeung]

@hsanson Command callback tests added

[hsanson]

ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.

# Add dense-analysis as remote upstream on your local fork. Not 
# needed if already added.
git remote add upstream https://github.com/dense-analysis/ale.git

# Sync your local master with upstream master
git checkout master
git fetch upstream master
git merge upstream/master

# Rebase the PR branch with master
git checkout my-branch-name
git rebase master   # Fix any conflicts you may have

# Force push the updated PR branch to origin to trigger the checks
git push -f origin my-branch-name

[nelsyeung]

Looks like it's all ready now!

[hsanson]

Ready to go, thanks.