-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dart analysis server to linter #3069
Add dart analysis server to linter #3069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using it locally and it's working well for me.
I just tested this PR locally. Functionally it works great. However, I am receiving the following noise in the command line area:
This appears every time I hit save, which is my trigger for a lint to occur. I am using Flutter It would be highly desirable to silently consume this particular message, it gets annoying fast. Best regards. |
I'm also seeing that, part of my config was hiding it so I didn't notice previously. |
sublimelsp/LSP#550 this issue describes it. |
How did you hide it? This PR probably should probably include that workaround. |
It's not applicable, it was being hidden because I was echoing a bunch of other messages. It would still show up in |
These issues are relevant: Correct me if I am wrong, but I think ALE may be sending I suspect ALE LSP code needs to be refined to not send As it stands at the moment, every Dart file save is triggering this alert which distracts from genuine lint messages. |
@bluz71 Do you think it's worth raising this as a separate issue and create a fix in a separate PR? |
Yes, it is a separate issue. It should not hold this up. I was going to create a new issue today, but got distracted with other stuff. I will do so soon. |
New issue, #3207, spawned about the This PR can be merged independent of that. This looks ready now. |
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
@w0rp This is certainly not stale and would love to be merged asap. |
Seconded. Looking forward to seeing this merged. |
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
@w0rp bump |
I agree, not stale. |
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
I'm not gonna lose this battle to a bot! |
Hello @nelsyeung please consider updating your patch with this tiny patch: 11c11
< return !empty(l:pubspec) ? fnamemodify(l:pubspec, ':h:h') : ''
---
> return !empty(l:pubspec) ? fnamemodify(l:pubspec, ':h:h') : '.' I've just changed it to return current dir when pubspec is not available. In this way it will support also standalone files. |
Anything missing? Out of the box support would be really great 👍 |
Nope, just waiting for review and merge. |
@hwasoocho Can you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tests. Check the test/command_callbak folder for examples on how to write tests for command callbacks.
@hsanson Command callback tests added |
ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.
|
Looks like it's all ready now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go, thanks.
Add Dart analysis_server to linter. Closes #1005