Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dafny: include correct filename in lint results #3390

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

benknoble
Copy link
Contributor

Results can come from included files, not just the current buffer.

Results can come from included files, not just the current buffer.
@benknoble
Copy link
Contributor Author

/cc @hsanson

@stale
Copy link

stale bot commented Nov 10, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Nov 10, 2020
@benknoble
Copy link
Contributor Author

/cc @w0rp

@stale stale bot removed the stale PRs a bot will close automatically label Nov 10, 2020
@stale
Copy link

stale bot commented Dec 8, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Dec 8, 2020
@benknoble
Copy link
Contributor Author

Not stale. /cc @w0rp again

@stale stale bot removed the stale PRs a bot will close automatically label Dec 9, 2020
@stale
Copy link

stale bot commented Jan 6, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Jan 6, 2021
@benknoble
Copy link
Contributor Author

Still not stale. /cc @w0rp

@stale stale bot removed the stale PRs a bot will close automatically label Jan 6, 2021
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and seems correct.

@hsanson hsanson merged commit 4c454c9 into dense-analysis:master Jan 6, 2021
@hsanson
Copy link
Contributor

hsanson commented Jan 6, 2021

@benknoble thanks for the persistence. I avoid reviewing or merging stuff I don't use on a daily basis since I have no way to properly test it but this change is small enough and I believe you use this frequently so it must work as expected.

benknoble added a commit to benknoble/ale that referenced this pull request Jan 23, 2021
@benknoble benknoble deleted the fix-dafny-filename branch October 4, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants