Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dafny: add a timeLimit option and message-parsing #3475

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

benknoble
Copy link
Contributor

@benknoble benknoble commented Nov 30, 2020

The option itself was manually tested.

The message-parsing has a new test.

#3390 should probably merge first, which will necessitate some updates to this PR.

@stale
Copy link

stale bot commented Dec 28, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Dec 28, 2020
@benknoble
Copy link
Contributor Author

@w0rp should be passing

@stale stale bot removed the stale PRs a bot will close automatically label Dec 28, 2020
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests in order too and no visible backward compatibility issues.

@hsanson hsanson merged commit 7b42dd7 into dense-analysis:master Jan 20, 2021
@benknoble
Copy link
Contributor Author

@hsanson should we update bufnr to filename now that #3390 is merged, too? I'm actually surprised the tests passed after that

@hsanson
Copy link
Contributor

hsanson commented Jan 20, 2021

@benknoble I do not use Dafny but from what I have read it seems using filenames would be useful in this case. It will allow ALE to show errors on files still not open (no buffer) in vim/nvim.

benknoble added a commit to benknoble/ale that referenced this pull request Jan 23, 2021
@benknoble benknoble deleted the dafny-include-timeouts branch October 4, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants