Add Ruby sorbet option to enable watchman #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's cool that it all works so fast, even though there are many moving pieces. Thanks for making ale quick :) |
|
posting to keep that sale bot away |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
|
Thanks! |
|
1337 closed pr 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2614
The sorbet support already in ale works great, and I think it makes sense to default to
--disable-watchmanas @rintaun did in the original PR.A little while ago I had hacked up my copy in my
.vimdir to remove that though, so files changed outside of vim (such as auto generated rbi files) would be picked up by the lsp server.I figured it'd be better to contribute that back up to ale though. I've done very little vim script though, so this was all just done by looking around the project a bit, so I'm not sure if things are wrong. It seems to work for me though, for what it's worth.