Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hadolint: Recognize message type #3472

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

m-ildefons
Copy link
Contributor

Hadolint is in the process of adding the severity of a lint rule to the
command line output: hadolint/hadolint#501

This change utilizes that to show the severity in vim.
This change also updates the tests on the Hadolint handler.

Hadolint is in the process of adding the severity of a lint rule to the
commandline output: hadolint/hadolint#501

This change utilizes that to show the severity in vim.
@stale
Copy link

stale bot commented Dec 27, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Dec 27, 2020
@stale stale bot closed this Jan 3, 2021
@m-ildefons
Copy link
Contributor Author

Hadolint now outputs rule severity. This should be reopened.
hadolint/hadolint#501

@hsanson hsanson removed the stale PRs a bot will close automatically label Jan 25, 2021
@hsanson hsanson reopened this Jan 25, 2021
@m-ildefons
Copy link
Contributor Author

Thanks @hsanson I don't know why, but it seems like three of the tests haven't started properly. I don't know how I can trigger a recheck.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go. Do not worry about the tests. These were added recently.

@hsanson hsanson merged commit 9b5c090 into dense-analysis:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants