Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3537 - remove -T argument from ruby linter #3538

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Fix 3537 - remove -T argument from ruby linter #3538

merged 1 commit into from
Feb 23, 2021

Conversation

hsanson
Copy link
Contributor

@hsanson hsanson commented Jan 13, 2021

Fixes #3537

@hsanson hsanson closed this Jan 13, 2021
@hsanson hsanson reopened this Jan 13, 2021
@hsanson hsanson closed this Jan 13, 2021
@hsanson hsanson reopened this Jan 13, 2021
@hsanson hsanson force-pushed the 3537-remove-ruby-taint-checks branch from 2c4691f to 56b7eb3 Compare January 22, 2021 14:16
@hsanson hsanson force-pushed the 3537-remove-ruby-taint-checks branch from 56b7eb3 to 4c78cae Compare January 27, 2021 22:56
@parkr
Copy link

parkr commented Feb 22, 2021

After the upgrade to Ruby 3 (out since Dec 2020, nearly 2 months), this is now failing:

(finished - exit code 1) ['/usr/local/bin/bash', '-c', '''ruby'' -w -c -T1 ''/var/folders/3f/mtbd3vyd1lb_jyvwgldzh1t80000gn/T/vtlWviD/2/foo.rb''']
<<<OUTPUT STARTS>>>
ruby: invalid option -T  (-h will show valid options) (RuntimeError)
<<<OUTPUT ENDS>>>

@parkr
Copy link

parkr commented Feb 22, 2021

@hsanson Is anyone able to approve this PR from your team of maintainers?

@hsanson hsanson merged commit 7696561 into dense-analysis:master Feb 23, 2021
@w0rp
Copy link
Member

w0rp commented Mar 1, 2021

Thanks for merging this. This is good to have.

@ahayworth ahayworth mentioned this pull request Oct 21, 2021
Merged
ahayworth added a commit to ahayworth/ale that referenced this pull request Oct 21, 2021
@ahayworth
Re-apply dense-analysis#3538 - remove -T argument from ruby linter
83c9d59 
The `-T` option (for "taint checking") was deprecated in ruby 2.7
and removed entirely in ruby 3.0. This causes the linter to fail
entirely for users of ruby 3.0.

This was reported in dense-analysis#3537, and then fixed in dense-analysis#3538 - but it seems as
though in 9fe7b1f, it was accidentally
and entirely undone.

This commit is essentially identical to dense-analysis#3538, aside from a path change
for the tests.
hsanson pushed a commit that referenced this pull request Oct 22, 2021
@ahayworth
Re-apply #3538 - remove -T argument from ruby linter (#3951)
95ba789 
The `-T` option (for "taint checking") was deprecated in ruby 2.7
and removed entirely in ruby 3.0. This causes the linter to fail
entirely for users of ruby 3.0.

This was reported in #3537, and then fixed in #3538 - but it seems as
though in 9fe7b1f, it was accidentally
and entirely undone.

This commit is essentially identical to #3538, aside from a path change
for the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkr parkr parkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ruby taint check that is deprecated.
3 participants
@hsanson @parkr @w0rp