Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ruby taint check that is deprecated. #3537

Closed
hsanson opened this issue Jan 13, 2021 · 0 comments · Fixed by #3538
Closed

Remove ruby taint check that is deprecated. #3537

hsanson opened this issue Jan 13, 2021 · 0 comments · Fixed by #3538
Labels
enhancement

Comments

@hsanson
Copy link
Contributor

hsanson commented Jan 13, 2021

From ruby 2.7 the taint checks (e.g. -T) are deprecated and will be completely removed from ruby 3.0. These taint checks were relevant when CGI was the norm but now they are barely an issue, therefore their deprecation.

Before ruby 3.0 becomes prevalent is better to remove the check or risk ALE stop working for people using ruby 3.0 or newer.

Currently ALEInfo shows the deprecation warning when working with ruby files:

<<<OUTPUT STARTS>>>
ruby: warning: ruby -T will be removed in Ruby 3.0
<<<OUTPUT ENDS>>>

Source: https://blog.saeloun.com/2020/02/18/ruby-2-7-access-and-setting-of-safe-warned-will-become-global-variable.html
@hsanson hsanson mentioned this issue Jan 13, 2021
Merged
@ahayworth ahayworth mentioned this issue Oct 21, 2021
Merged
ahayworth added a commit to ahayworth/ale that referenced this issue Oct 21, 2021
@ahayworth
Re-apply dense-analysis#3538 - remove -T argument from ruby linter
83c9d59 
The `-T` option (for "taint checking") was deprecated in ruby 2.7
and removed entirely in ruby 3.0. This causes the linter to fail
entirely for users of ruby 3.0.

This was reported in dense-analysis#3537, and then fixed in dense-analysis#3538 - but it seems as
though in 9fe7b1f, it was accidentally
and entirely undone.

This commit is essentially identical to dense-analysis#3538, aside from a path change
for the tests.
hsanson pushed a commit that referenced this issue Oct 22, 2021
@ahayworth
Re-apply #3538 - remove -T argument from ruby linter (#3951)
95ba789 
The `-T` option (for "taint checking") was deprecated in ruby 2.7
and removed entirely in ruby 3.0. This causes the linter to fail
entirely for users of ruby 3.0.

This was reported in #3537, and then fixed in #3538 - but it seems as
though in 9fe7b1f, it was accidentally
and entirely undone.

This commit is essentially identical to #3538, aside from a path change
for the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 3537 - remove -T argument from ruby linter hsanson/ale
1 participant
@hsanson