Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make markdown vale linter command configurable with options #3594

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Make markdown vale linter command configurable with options #3594

merged 3 commits into from
Feb 18, 2021

Conversation

dbalatero
Copy link
Contributor

My work uses a custom Vale setup, and I need to pass in some extra options to get it working with ALE.

I followed the same style as the Rubocop linter:

https://github.com/dbalatero/ale/blob/414d322dc88a52453c1140a41227ad53209228c5/ale_linters/ruby/rubocop.vim#L4-L14

This adds Vimscript config options for executable path, input file, and additional CLI options. It also adds tests as requested in the PR template.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good contribution. Thanks.

@hsanson hsanson merged commit 0b35c3a into dense-analysis:master Feb 18, 2021
@dbalatero
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants