Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for clangd with CUDA #3598

Merged
merged 4 commits into from
Mar 20, 2021
Merged

Conversation

oToToT
Copy link
Contributor

@oToToT oToToT commented Feb 20, 2021

I think clangd actually supports CUDA, so I simply copy some code from clangd support with C++ to get support for CUDA.
I didn't write any tests since I think the C/C++ version tests works fine.

@stale
Copy link

stale bot commented Mar 20, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs a bot will close automatically label Mar 20, 2021
@oToToT
Copy link
Contributor Author

oToToT commented Mar 20, 2021

Hi, @w0rp are you willing to check this? Or maybe I should do something more?
I think this would help some CUDA developers who use clangd.

@stale stale bot removed the stale PRs a bot will close automatically label Mar 20, 2021
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a test file for this.

@w0rp w0rp merged commit 3728d9f into dense-analysis:master Mar 20, 2021
@w0rp
Copy link
Member

w0rp commented Mar 20, 2021

Cheers! 🍻

@hsanson hsanson mentioned this pull request Mar 21, 2021
@oToToT oToToT deleted the cuda-clangd branch March 21, 2021 05:50
jsit added a commit to jsit/ale that referenced this pull request Mar 30, 2021
* master: (214 commits)
  improve DMD handler (dense-analysis#3647)
  Add support for V: "v" (compiler) and "vfmt" fixer. (dense-analysis#3622)
  Add nixfmt as a Nix fixer. (dense-analysis#3651)
  Switch to using buildifier's -path option (dense-analysis#3640)
  Add support for `ptop` fixer (dense-analysis#3652)
  Add more parameters to the DMD linting command (dense-analysis#3639)
  dense-analysis#3633 - Move linter tests into test/linter
  Allow more time before PRs become stale
  Add support for clangd with CUDA (dense-analysis#3598)
  add support for svelte via svelteserver language server (dense-analysis#3644)
  dense-analysis#3633 - Put all dummy test files in test/test-files
  Add desktop-file-validate
  Fix a typo in a test filename
  issue 3033 (dense-analysis#3620)
  dense-analysis#3632 Add ale#util#MapMatches
  Fix ale#path#Dirname on Windows
  Disable blank issues and add a link to ask for help
  Check user systemd unit files with systemd-analyze
  Close dense-analysis#2102 - Add support for the Angular language server
  Fix texlab#GetProjectRoot (dense-analysis#3610)
  ...
jsit added a commit to jsit/ale that referenced this pull request Apr 19, 2021
* origin/master: (219 commits)
  Updated `solhint` linter to be able to use a local installation (dense-analysis#3682)
  Don't exit visual mode on floating preview close (dense-analysis#3689)
  hadolint: fix color output and stdin shown as "-" (dense-analysis#3680)
  feat: Add protolint as linter and fixer (dense-analysis#2911)
  apple-swift-format: linter and fixer with config swiftpm support (dense-analysis#3671)
  improve DMD handler (dense-analysis#3647)
  Add support for V: "v" (compiler) and "vfmt" fixer. (dense-analysis#3622)
  Add nixfmt as a Nix fixer. (dense-analysis#3651)
  Switch to using buildifier's -path option (dense-analysis#3640)
  Add support for `ptop` fixer (dense-analysis#3652)
  Add more parameters to the DMD linting command (dense-analysis#3639)
  dense-analysis#3633 - Move linter tests into test/linter
  Allow more time before PRs become stale
  Add support for clangd with CUDA (dense-analysis#3598)
  add support for svelte via svelteserver language server (dense-analysis#3644)
  dense-analysis#3633 - Put all dummy test files in test/test-files
  Add desktop-file-validate
  Fix a typo in a test filename
  issue 3033 (dense-analysis#3620)
  dense-analysis#3632 Add ale#util#MapMatches
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants