Fix texlab#GetProjectRoot #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanson
reviewed
Mar 4, 2021
ale_linters/tex/texlab.vim
Outdated
| return '' | ||
| let l:project_root = ale#path#FindNearestDirectory(a:buffer, '.git') | ||
|
|
||
| return !empty(l:project_root) ? fnamemodify(l:project_root, ':h') : fnamemodify(a:buffer, ':h') |
There was a problem hiding this comment.
Returning the directory of the current buffer when no .git directory is found may cause ALE to spawn an instance of the language server for every tex file open. See the comment about this: #2501 (comment)
Here would be better to return an empty string if no root is found.
There was a problem hiding this comment.
Good point. I personally didn't mind an LSP server starting for every tex file, but I agree it would not be preferred as the default. I will fix that now, and I'll also try to fix the tests after I understand them more.
|
please fix the failing test so I can merge this: |
Previously, the function returned `../.git/`. We want the function to return the parent directory above that as the project root. This should help pass Vader tests.
|
@hsanson Tests should be fixed now. Thank you for the review! |
This was referenced Mar 15, 2021
jsit
added a commit
to jsit/ale
that referenced
this pull request
Mar 30, 2021
* master: (214 commits) improve DMD handler (dense-analysis#3647) Add support for V: "v" (compiler) and "vfmt" fixer. (dense-analysis#3622) Add nixfmt as a Nix fixer. (dense-analysis#3651) Switch to using buildifier's -path option (dense-analysis#3640) Add support for `ptop` fixer (dense-analysis#3652) Add more parameters to the DMD linting command (dense-analysis#3639) dense-analysis#3633 - Move linter tests into test/linter Allow more time before PRs become stale Add support for clangd with CUDA (dense-analysis#3598) add support for svelte via svelteserver language server (dense-analysis#3644) dense-analysis#3633 - Put all dummy test files in test/test-files Add desktop-file-validate Fix a typo in a test filename issue 3033 (dense-analysis#3620) dense-analysis#3632 Add ale#util#MapMatches Fix ale#path#Dirname on Windows Disable blank issues and add a link to ask for help Check user systemd unit files with systemd-analyze Close dense-analysis#2102 - Add support for the Angular language server Fix texlab#GetProjectRoot (dense-analysis#3610) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the texlab#GetProjectRoot function based on the discussion in #2501 of using a .git folder as an indicator of a TeX project root. This should address the issue of the texlab LSP server not starting at all, as raised by #2790 and #2699