Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3801 - Add ALEDummySign some width. #3832

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

hsanson
Copy link
Contributor

@hsanson hsanson commented Jul 21, 2021

Due to changes in NeoVim 0.5 the g:ale_sign_column_always configuration
stopped working.

This PR sets the ALEDummySign to a blank space so when g:
ale_sign_column_always is set we have a sign with 1 width allowing the
configuration to work as before.

Due to changes in NeoVim 0.5 the g:ale_sign_column_always configuration
stopped working.

This PR sets the ALEDummySign to a blank space so when g:
ale_sign_column_always is set we have a sign with 1 width allowing the
configuration to work as before.

neovim/neovim#13635
@hsanson hsanson requested a review from w0rp July 21, 2021 00:38
@RobbieClarken
Copy link

RobbieClarken commented Jul 21, 2021

I've confirmed this fixes the issue where g:ale_sign_column_always wasn't having any effect in neovim nightly (v0.6.0-dev+nightly-169-gd791274a9).

Unfortunately it introduces a small rendering issue where the first two cells on the first line are styled incorrectly:

Screen Shot 2021-07-21 at 10 36 35 am

This only happens if g:ale_sign_column_always is set to 1 and it happens for vim 8.2 as well as neovim nightly. It doesn't happen for vim or neovim without this patch.

My colorscheme is gruvbox-dark-hard from chriskempson/base16 but I've also confirmed the rendering issue happens with morhetz/gruvbox.

@hsanson
Copy link
Contributor Author

hsanson commented Jul 21, 2021

@RobbieClarken thanks for testing. I was unable to see that artifact due to my colorscheme, good thing to have others check in their setups.

I have made a small modification, please let me know if it solves the rendering issue.

@RobbieClarken
Copy link

@hsanson That fixes the rendering in both vim and neovim. Everything looks to be working perfectly now. 👏

@hsanson hsanson enabled auto-merge (squash) July 21, 2021 09:25
@hsanson hsanson disabled auto-merge July 21, 2021 09:25
@hsanson hsanson merged commit 5ad4fdd into dense-analysis:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign gutter not opened by default in Neovim v0.5
2 participants