Fix truncated echo #3889
Merged
Fix truncated echo #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In typescript, when putting the cursor on a `>` character of an arrow function, the displayString body comes back as an empty string, and means the split operation has 0 items, causing a failure when attempting to call TruncatedEcho. Even if there's a better fix, I'd assume this is a good safety since we are injesting external data.
hsanson
requested changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In typescript, when putting the cursor on a
>character of an arrow function, thebody.displayStringcomes back as an empty string, and means the split operation has 0 items, causing a failure when attempting to call TruncatedEcho with the 0 index.Even if there's a better fix, I'd assume this is a good safety since we are ingesting external data?
Should fix #3512