Fix: Failed to execute rubocop fixer on other machine

[uplus]

Expectation

I want to apply the fixer of rubocop in the container to the Ruby file that is volume mounted by docker-compose.
Use b:ale_command_wrapper and b:ale_filename_mappings to run fixer inside docker.

let b:ale_command_wrapper = 'docker-compose exec -T api bundle exec'
let b:ale_filename_mappings = { '*': [['/home/uplus/project', '/usr/src/app']] }

Problem

Linter succeeded, but Fixer failed.

Linter Log(succeeded)

['/bin/sh', '-c', 'docker-compose exec -T api bundle exec ''rubocop'' --format json --force-exclusion  --stdin ''/usr/src/app/Rakefile'' < ''/tmp/nvimSHY0Hz/2/Rakefile''']

Fixer Log(failed)

['/bin/sh', '-c', 'docker-compose exec -T api bundle exec ''rubocop'' --config ''/home/uplus/project/.rubocop.yml'' --auto-correct --force-exclusion --stdin ''/usr/src/app/Rakefile'' < ''/tmp/nvimSHY0Hz/3/Rakefile''']

Cause

Fixer fails because host filepath is passed to --config of rubocop in the container.
Files targeted by Fixer are mapped as specified in b:ale_filename_mappings, but file path of --config are not mapped.
Rubocop does not work because --config specified an invalid file path.

['/bin/sh', '-c', 'docker-compose exec -T api bundle exec ''rubocop'' --config ''/home/uplus/project/.rubocop.yml'' --auto-correct --force-exclusion --stdin ''/usr/src/app/Rakefile'' < ''/tmp/nvimSHY0Hz/3/Rakefile''']
                                                                                 ^^^^^^^^^^^^^^^^^^^                                                           ^^^^^^^^^^^^
                                                                                 Host machine filepath(not mapped)                                             Container filepath(mapped)

Solution

This problem can be resolved by removing --config.

Fixer Log(succeeded)

['/bin/sh', '-c', 'docker-compose exec -T api bundle exec ''rubocop'' --auto-correct --force-exclusion --stdin ''/usr/src/app/Rakefile'' < ''/tmp/nvimwyKaEQ/6/Rakefile''']

According to the commit log, ALE specifies --config to resolve #732.
At that time, there seemed to be a problem that .rubocop.yml was not loaded when using rubocop fixer from ALE.

However current rubocop fixer reads .rubocop.yml even if ALE doesn't specify --config.
Also, in previous implementations, fixer specified --config, but linter did not specify --config, so the behavior could be different.

If ALE user wants to specify --config, it can be specified with g:ale_ruby_rubocop_options.

[hsanson]

Thanks, fix looks good.

[uplus]

Thanks for your review!