ALEFileRename command added. #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command renames file and uses tsserver `getEditsForFileRename` to fix import paths in Typescript files.
|
@hsanson please review, I'm not sure who else could check this. |
hsanson
requested changes
Dec 15, 2021
There was a problem hiding this comment.
I do not have the setup to test this on my machine but looks good to me. It only needs some polishing for when someone runs ALERename when another LSP is running.
For example running ALERename with pyright LSP active shows "E488: Trailing characters" error.
Also running ALERename with no arguments results in "E119: Not enough arguments for function: ale#util#Input" error. Would be better to detect the command is being wrongly used and show a more user friendly error message.
|
I think it is good now. Tested with pyright - no problem. It seems all the problems were related to ale#util#Input change. |
hsanson
requested changes
Dec 16, 2021
hsanson
approved these changes
Dec 16, 2021
|
🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command renames file and uses tsserver
getEditsForFileRenametofix import paths in Typescript files.