Fix 4086 - use stable command options for rustc #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nospam2998
reviewed
Feb 19, 2022
| @@ -5,7 +5,7 @@ After: | |||
| call ale#assert#TearDownLinterTest() | |||
|
|
|||
| Execute(The default command should be correct): | |||
| AssertLinter 'rustc', 'rustc --error-format=json -Z no-codegen -' | |||
| AssertLinter 'rustc', 'rustc --error-format=json --emit=mir -o /dev/null -' | |||
There was a problem hiding this comment.
Ooops! I missed these, sorry. Great that you caught them! Thanks!
nospam2998
approved these changes
Feb 19, 2022
There was a problem hiding this comment.
It would not surprise me if this change makes the rustc linter suddenly work for a lot of users, and that they will thus end up with duplicate lints from rustc and cargo.
I could argue that excluding this linter by default would be a sane default, as essentially everyone will get duplicates and prefer their linting through cargo. That's a different change though, as merging this still improves the situation.
|
@nospam2998 actually rustc is disabled by default. From the docs: And checking ALE's code this is indeed the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4086