Don't echom if not in normal mode #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
approved these changes
Jul 31, 2023
|
I'll merge this and see if this somehow causes anything to go wrong. |
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running into this issue for a couple years now: #3621 where often times I would make a visual selection only to be interrupted and booted out of visual mode back into normal mode and finally decided to do some digging into how to fix it.
w0rp suggested a fix which I've attempted to apply to the
ale#cursor#Echommethod. Not entirely sure if this is the right way to fix it, but using it for a day it definitely hasn't repro'd for me since