Add Ruby linter with Steep #4671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LSP presents a few issues and this works around those.
lloeki
force-pushed
the
feature/ruby-steep-linter
branch
from
2e74504
to
5e84dea
Compare
w0rp
requested changes
Dec 7, 2023
| endfunction | ||
|
|
||
| " Handle output from steep | ||
| function! ale_linters#ruby#steep#HandleOutput(buffer, lines) abort |
There was a problem hiding this comment.
This is a complex handler function. Add a test for this too. There's a directory for testing functions for handling results.
There was a problem hiding this comment.
I should finally be able to get back to complete this within a few weeks.
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4376
Fixes #3254
Working on it (trying to run the test docker thingy).Added tests (inspired by Rubocop ones)