Add linter for Idris #838
Merged
Add linter for Idris #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Aug 10, 2017
doc/ale-idris.txt
Outdated
| ALE Idris Integration *ale-idris-options* | ||
|
|
||
| =============================================================================== | ||
| idris *ale-idris-stack-build* |
There was a problem hiding this comment.
The help tag is wrong here. It should be ale-idris-idris, as in the table of contents.
doc/ale-idris.txt
Outdated
| @@ -0,0 +1,10 @@ | |||
| =============================================================================== | |||
| ALE Idris Integration *ale-idris-options* | |||
There was a problem hiding this comment.
Align the help tags to the right margin. If you use :ALEFixSuggest, it will suggest a function for fixing this.
ale_linters/idris/idris.vim
Outdated
| call ale#linter#Define('idris', { | ||
| \ 'name': 'idris', | ||
| \ 'executable': 'idris', | ||
| \ 'command': 'idris --total --warnpartial --warnreach --warnipkg --check %t', |
There was a problem hiding this comment.
You should make the non-essential options configurable, and add Vader tests with a callback.
|
Thank you for the feedback @w0rp. I believe I've addressed your concerns, please take another look. |
|
Cheers! 🍻 |
rsrchboy
added a commit
to rsrchboy/ale
that referenced
this pull request
Aug 13, 2017
* upstream/master: dense-analysis#653 - Fix loclist jumping so it works with buffer numbers Fix a failing test dense-analysis#653 - Include the buffer number in sorting of items dense-analysis#653 - Update the loclist binary search to work with buffer numbers, to filter out items for other buffers dense-analysis#468 - Do not try to echo things for a while if something goes wrong Use a shorter default completion delay, which works better Add a fix function for breaking up long Python lines, which is hidden for now Ban !=# and !=? from the codebase dense-analysis#653 - Pass on filenames for loclist items Add linter for Idris (dense-analysis#838) Pass extra rubocop options in the middle instead, and fix the Vader test so it can be run multiple times in Vim Rubocop fixer now uses g:ale_ruby_rubocop_options (dense-analysis#841) Automatically check for invalid help tag references, and fix some existing documentation issues Fix documentation for the PHP langserver options Fix some broken tag links Move --format=default in the flake8 command to the return value, and remove extra spaces in the tests Add support for SwiftFormat as a fixer Fix link for SwiftLint Default flake8 to --format=default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.