Passthrough eslint config to prettier-eslint

[morhetz]

closes #853

• depends on feat(options): allow specifying eslint configuration file as an argument prettier/prettier-eslint-cli#91
• update the documentation to indicate the minimum supported version
• fallback option (legacy)

[w0rp]

I'll close this for now, as no release of the tool implements this argument.

[w0rp]

Oh, 4.2.0 does, as of less than half an hour ago.

I'll reopen this. What you should do is leave this off by default, and add an option for turning this behaviour on. Then edit the documentation to explain this. It can be turned on by default after enough people upgrade.

[w0rp]

Are there older versions of prettier-eslint-cli with this path? If so, leave this in, but move it down the List.

[morhetz]

Nope. There were no version with this path

[w0rp]

Okay, cool. 👍

[morhetz]

@w0rp

What you should do is leave this off by default, and add an option for turning this behaviour on. Then edit the documentation to explain this. It can be turned on by default after enough people upgrade.

Hm, this fixer was never working as it supposed to due to wrong exec path and lack of eslint config passing. Best case it was working just as plain prettier.js formatter having no eslint --fix functionality. So there are zero to none users of it.

Wouldn't it be better/easier to engage users to upgrade prettier-eslint-cli package?

[morhetz]

Leaving this option off by default would still keep fixer broken and unusable

[w0rp]

If you set the argument by default, then the integration will stop working for people who are using the plugin who haven't yet upgraded prettier-eslint-cli.

[w0rp]

New options for any tool can't be used by default until some time has passed and people have the opportunity to upgrade first.

[morhetz]

Integration is not working without that option

[morhetz]

It's not just a new one, it's core functionality of prettier-eslint

[w0rp]

Maybe an exception could be made here, as the configuration file is pretty important.

[w0rp]

I think let's go with it. Update the documentation to indicate the minimum supported version, and cover the new argument with Vader tests.

[w0rp]

I would rather there weren't so many tools for doing essentially the same thing. Personally, I wish that standard, xo, prettier-standard, and prettier-eslint didn't exist. eslint with eslint-plugin-prettier is probably the best option. Running eslint --fix followed by prettier is probably the second best option.

Still, some people like this, so it's worth supporting.

[morhetz]

As far as I know eslint-plugin-prettier would require eslint-config-prettier to disable all format conflicting rules on the eslint side
prettier-eslint gives opportunity to use your preffered code style with no change
more like a drop in replacement for the eslint --fix inferring formatting options of the eslintrc

[morhetz]

@w0rp could you please review when you have a time?

[w0rp]

Looks pretty good so far. Now you can add some Vader tests to cover the command and the new option.

[w0rp]

I have added tests for this and merged this now. I also had to fix an issue where an empty configuration filename would sometimes be used.

[w0rp]

Cheers! 🍻