feat(options): allow specifying eslint configuration file as an argument #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
reviewed
Aug 16, 2017
| @@ -47,6 +49,11 @@ function formatFilesFromArgv({ | |||
| prettierLast, | |||
| prettierOptions, | |||
| } | |||
|
|
|||
| if (eslintConfigPath) { | |||
| prettierESLintOptions.eslintConfig = ConfigFile.load(eslintConfigPath) | |||
There was a problem hiding this comment.
Could we get a test for this? I'd be fine if you wanted to add // istanbul ignore if on line 52 because testing this in the unit tests would be tough, but then we could add this to the dist-tests. Could you do that please? That'd be swell!
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 105 107 +2
=====================================
+ Hits 105 107 +2
Continue to review full report at Codecov.
|
3 tasks
|
🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--eslint-config-pathcli optionConfig file parsing and resolution is on behalf of eslint
ConfigFilebase funcCloses #37