Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier_d fixer path #885

Merged
merged 1 commit into from Aug 29, 2017
Merged

Conversation

morhetz
Copy link
Contributor

@morhetz morhetz commented Aug 29, 2017

Add prettier_d to prettier bin lookup

@w0rp
Copy link
Member

w0rp commented Aug 29, 2017

Could probably use a test, but this looks fine to me.

@w0rp w0rp merged commit 87fb723 into dense-analysis:master Aug 29, 2017
@w0rp
Copy link
Member

w0rp commented Aug 29, 2017

Cheers! 🍻

@jonleopard
Copy link

Will ale check for prettier_d or eslint_d that are installed globally with Yarn? I can submit a quick PR if this isn't the case.

@w0rp
Copy link
Member

w0rp commented Jul 15, 2018

No, but you can change your settings to point to that executable with the _executable and _use_global options. I recommend installing everything locally in node_modules.

@jonleopard
Copy link

Thanks for the info! I mistakenly thought that 'node_modules/.bin/prettier_d', was the global path that ale looks at, so I was going to add yarn's global path to the prettier fixer file (since I use yarn for global package installations).

Thanks for clearing that up for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants