Add support for prettier configuration file. #886
Conversation
|
For some reason the test fail on the CI but pass on my machine. 🤔 Investigating. |
|
(Forgot to include the test prettier configuration file in the patch 😅) |
|
Using the argument with an older version doesn't seem to break, but prints a message to stderr. When you say adding an option, do you mean adding something like a |
|
Oh, does it ignore the additional argument? I'd expect that most programs would just stop working entirely if you use an invalid argument. |
|
Yup it ignores it on prettier 1.5.0, I haven't tried previous versions. But you're right it is probably safer to add an option in case previous versions don't ignore the argument. What do you think about the |
|
I think it would be best to add an option in ALE specific to prettier, like |
|
Oops, yeah that's what I meant 😅 |
As of version 1.6.0, prettier allows passing a `--config` argument with a path to a configuration file.
|
Added the |
|
|
||
| return { | ||
| \ 'command': ale#Escape(ale#fixers#prettier#GetExecutable(a:buffer)) | ||
| \ . ' %t' | ||
| \ . ' ' . l:options | ||
| \ . (!empty(l:options) ? ' ' . l:options : '') | ||
| \ . (l:use_config ? ' --config ' . ale#Escape(l:config) : '') |
There was a problem hiding this comment.
You also need to check !empty(l:config) here.
There was a problem hiding this comment.
You could use && !empty(l:config) for the value of l:use_config above.
| *b:ale_javascript_prettier_use_local_config* | ||
| Type: |Number| | ||
| Default: `0` | ||
|
|
There was a problem hiding this comment.
Add a short description here explaining what the option does when set to 1.
|
Updated. |
|
Cheers! 🍻 |
* upstream/master: Make the check-supported-tools-tables script work on more machines Add a missing scriptencoding line Add support for prettier configuration file. (dense-analysis#886)
As of version 1.6.0,
prettierallows passing a--configargument with a path to a configuration file.This PR adds support for this argument when a configuration file is present and some tests inspired by the rubocop fixer tests.