Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deoplete-jedi doesn't show all completion candidates that jedi-vim can #89

Closed
monkoose opened this issue Nov 30, 2016 · 11 comments
Closed
Labels

Comments

@monkoose
Copy link

monkoose commented Nov 30, 2016

Problem summary

This issue needs a confirmation. Because i'm not sure is it something with my config or deoplete-jedi problem itself.
There is no candidates for something like django's admin.site. ....
or deoplete-jedi doesn't show candidates for statements inside django's classes, etc.

class BookAdmin(admin.ModelAdmin):
    list_display

Expected

jedi-vim candidates

  • Neovim version:
    0.1.6
@blueyed blueyed added the bug label Nov 30, 2016
@blueyed
Copy link
Collaborator

blueyed commented Nov 30, 2016

Confirmed/reproduced.

@Shougo
Copy link
Collaborator

Shougo commented Nov 30, 2016

@tweekmonster @zchee Ping

@tweekmonster
Copy link
Collaborator

Looking into this

@monkoose
Copy link
Author

monkoose commented Dec 1, 2016

Thank you @tweekmonster
And for your djangoplus too:)

@monkoose
Copy link
Author

monkoose commented Dec 1, 2016

By the way this problem was not only for django.
Same problem was with importing numpy. And i bet with other packages.

@zchee
Copy link
Member

zchee commented Dec 1, 2016

@monkoose Thanks share the detail. Now has been merged #90. Try fetch the master branch.

@tweekmonster @blueyed @Shougo
I would appreciate your cooperation. Thanks.

@blueyed
Copy link
Collaborator

blueyed commented Dec 1, 2016

I would appreciate your cooperation

There is nothing left to be done here, is there?
Or did I misunderstood, and you wanted to thank us? 😕 :)

@zchee
Copy link
Member

zchee commented Dec 1, 2016

@blueyed Oh? Did I say bad English? Sorry.
In other words, I am grateful for all your help.

@monkoose
Copy link
Author

monkoose commented Dec 1, 2016

@tweekmonster @blueyed @zchee Thanks again. Works perfect for described problems.

But tested with numpy(even larger package then django and more comlex) and seems like it still cant show some candidates that JEDI(and jedi-vim) can. Tested in atom and vscode too. They both can complete(atom need like 5-10 sec to actually recognize this candidates. Yes numpy is huge), vscode much faster but still delays 2-3 seconds before comletions show up.
I dunno - maybe it's too much for deoplete-jedi and deoplete itself? Because my neovim even freeze for few seconds when im trying to get this completions with jedi-vim
Some screenshots
deoplete-jedi

jedi-vim

atom

As you can see from jedi-vim screenshot actual path for sin is numpy.umath.sin. And as expecting deoplete-jedi completes it without a problem

So i dont really know should we try to fix this. Because it's laggy. Just posted for the record.

@zchee
Copy link
Member

zchee commented Dec 1, 2016

@monkoose Oh, it's might create new issue thread is good. Could you create issue?

But deoplete-jedi was a freeze? IIRC deoplete-jedi using json cache for import module when the first method. numpy is larger is correct, but if already cached module method, take a 0.5 sec for show completion word list.
So, maybe deoplete-jedi was not freeze at your situation. Caused by wrong cached module method, or not support as...? not sure.
I'll check it.

Anyway, each major editor's results is a very good reference for us. IIRC there are no each editor's benchmark (like benchmark tool). Thanks.

@monkoose
Copy link
Author

monkoose commented Dec 1, 2016

Then i will create new issue just with almost identical post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants