Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redis deprecations #18

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Fix redis deprecations #18

merged 2 commits into from
Apr 8, 2022

Conversation

rileyanderson
Copy link
Contributor 

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.#{method} do
  redis.get("key")
end
should be replaced by:

redis.#{method} do |pipeline|
  pipeline.get("key")
end

@rileyanderson rileyanderson marked this pull request as ready for review April 8, 2022 14:12
ericboehs
ericboehs approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@ericboehs ericboehs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rileyanderson rileyanderson merged commit e404392 into master Apr 8, 2022
@ericboehs ericboehs deleted the ra-redis-deprecations branch April 8, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericboehs ericboehs ericboehs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rileyanderson @ericboehs