Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create attorney special issues page #6854

Closed
lpciferri opened this issue Sep 6, 2018 · 7 comments
Closed

Create attorney special issues page #6854

lpciferri opened this issue Sep 6, 2018 · 7 comments

Comments

@lpciferri
Copy link
Contributor

lpciferri commented Sep 6, 2018

For the RAMP appeals pilot, we want to experiment with attorneys entering special issues (that today are entered by ARC staff in Caseflow Dispatch) because (1) this simplifies the amount of work we have to do for dispatching RAMP appeals today and (2) we plan to deprecate Caseflow Dispatch down the line anyway.

AC

  • Create a screen titled Select special issues
  • Select special issues screen comes after selecting remand reasons in the checkout flow
  • The following special issues should be listed on this page (TODO)

Background

See mural for flow.

This is how special issues are displayed in Caseflow Dispatch. Let's replicate it.
screen shot 2018-09-06 at 7 12 30 pm

Mocks

image

@lpciferri
Copy link
Contributor Author

lpciferri commented Sep 11, 2018

@mdbenjam - I got the answer from AMO that these special issues do not apply for RAMP appeals, so we should remove them from the Special issues page:

  • Vocational Rehab
  • DIC - death, or accrued benefits - United States
  • Education - GI Bill, dependents educational assistance
  • Foreign pension, DIC - Mexico, Central and South America, Caribbean
  • Foreign pension, DIC - all other foreign countries
  • Home Loan Guaranty
  • Insurance
  • National Cemetery Administration
  • Pension - United States
  • VAMC
  • Waiver of Overpayment
  • Scholarship, transfer of entitlement

Resource: #6903

va-bot pushed a commit that referenced this issue Sep 12, 2018
Connects #6854 

### Description
This PR is the first part of adding special issues. It creates a new special issues table that is polymorphicly associated with both the appeal and legacy appeal tables. It also creates a special issues endpoint the page can use to update and get the currently selected special issues.

The PR also creates the frontend for special issues. It currently doesn't live within the attorney & judge checkout flows but will in the next PR. 

### Testing Plan
1. Insert the page into the flow by changing `SelectDispositionsView`'s `prevPage` to `/queue/appeals/${props.match.params.appealId}/special_issues` and updating the `      draft_decision` key in AttorneyActionsDropdown to be `special_issues` instead of `dispositions`.
1. Go through attorney checkout flow, check all the boxes, click next
1. Restart the flow and ensure all the boxes are still checked.
va-bot pushed a commit that referenced this issue Sep 12, 2018
Resolves #6854  

### Description
This PR finishes the special issue flow.

1) Inserts it into the AMA flow, but not the legacy flow.
1) Removes non-compensation special issues
1) Adds a test

### Testing Plan
1. Log in as BVASCASPER and chose the first case (it's an AMA case)
1. Go through the draft decision checkout flow
1. Ensure the first page is a special issues page.
1. Select things, hit continue.
1. Cancel and redo the flow ensure the same boxes are checked.
@lpciferri
Copy link
Contributor Author

lpciferri commented Sep 18, 2018

@mdbenjam

Option 1: Remove the below for AMA appeals:

  • Hearing
  • Manlincon Compliance
    Both of these are not relevant for AMA.

Option 2: If you don't want to fork these two pages based on if an appeal is legacy or AMA in the future, you can append them

  • Hearing ... (legacy appeals only) This should also be removed for legacy appeals (when we have time to do so in Caseflow Dispatch).
  • Manlincon Compliance (legacy appeals only)

@allyceh
Copy link
Contributor

allyceh commented Nov 8, 2018

@laurjpeterson Is this the one we should re-open for design + content for the special issues page?

When shadowing an attorney working a RAMP case yesterday, she saw the special issues page for the first time and noticed it was new. She understood it after we explained it to her, but some additional context around 1) what these special issues are, 2) what the attorney needs to do on this page, 3) how we use any special issues they check (routing purposes) could help orient first time users.

Additionally, she missed the POA/agent special issue checkbox (located at the bottom left of the page) and only realized it when we asked her to return to the page. Should we make this more prominent since the majority of cases have POA? Should it be the first special issue if it's the most common? Can we default the POA checkbox if a veteran has a POA in VBMS?

@lpciferri
Copy link
Contributor Author

@allyceh - this is the ticket that includes fixing the copy for this page - #7036. If we don't use this ticket, I suggest we create a new one to track your copy suggestions.

I agree that we should include the three things you mentioned ( 1) what these special issues are, 2) what the attorney needs to do on this page, 3) how we use any special issues they check (routing purposes) could help orient first time users.)

Should we make this more prominent since the majority of cases have POA?

  • This is only tracking private attorney or agent. Yes, the majority have cases have a POA, but many more have VSOs as their POA. If you think we should move this checkbox up, that works for me!

Can we default the POA checkbox if a veteran has a POA in VBMS?

  • Yes, we could probably pre-check this checkbox in the future if we can tell that the POA is an attorney or agent in VBMS. I'm not certain if we can distinguish VSO from private attorney/agent.
  • Side note: Shane and I went through the AMA related special issues and we realized that quite a few of the special issues could be pre-checked in the future. I think this will come with the Outcoding, VBMS upload, and EP creation effort.

@allyceh
Copy link
Contributor

allyceh commented Nov 9, 2018

Moving this convo to #7036!

@allyceh
Copy link
Contributor

allyceh commented Dec 27, 2018

@laurjpeterson @aroltsch Latest mock is above for copy review. Updated based on @nicholasholtz feedback.

@allyceh
Copy link
Contributor

allyceh commented Jan 4, 2019

@laurjpeterson @aroltsch An updated mock for the special issues page for AMA appeals is ready as well. I ended up doing both since they were easy to update simultaneously.

Since attorneys will be seeing the updated verbiage and categorization for legacy appeals, can we also update the AMA special issues screen so that the experience is consistent for them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants