Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create add decisions page with just request issues #7958

Closed
lpciferri opened this issue Nov 21, 2018 · 0 comments
Closed

Create add decisions page with just request issues #7958

lpciferri opened this issue Nov 21, 2018 · 0 comments
Assignees
@mdbenjam @allyceh
Labels
Feature: case-details Feature: caseflow-decisions Team: Foxtrot 🦊

Comments

@lpciferri
Copy link
Contributor

lpciferri commented Nov 21, 2018 •
edited by allyceh

Part of Editing AMA issues

When attorneys are ready to check a case out to their judge, they need to add decisions (issue + disposition) for each request issue.

AC

Attorneys:

  • When the attorney clicks "Decision ready for review", they navigate to the new Add decisions screen (and not the Select dispositions screen that exists for legacy appeals)

Judges:

  • This is replicated for judges. When the judge clicks "Ready for dispatch", they navigate to this page. However, let's title it Review decisions instead of Add decisions like we do for legacy.

Both:

  • Populate all request issues on the Add decisions screen per mocks
  • A button exists beneath each request issue, per mocks.
  • When there isn't a note captured by Intake, hide the "Notes" field.

Mocks

image
@lpciferri lpciferri changed the title AMA attorney/judge checkout | Create add decisions page Create add decisions page Nov 21, 2018
@lpciferri lpciferri mentioned this issue Nov 21, 2018
Closed
@lpciferri lpciferri changed the title Create add decisions page Create add decisions page with just request issues Nov 21, 2018
@mdbenjam mdbenjam mentioned this issue Nov 26, 2018
Merged
va-bot pushed a commit that referenced this issue Nov 27, 2018
@mdbenjam
Issue editing frontend (#7962)
f63a078 
Connects: #7957, Connects: #7958, Connects: #7965

### Description
This PR begins adding the editing issue frontend.

1) Update the case details page to show the new AMA issue style.
2) Create a new select disposition page (screenshot below).
3) Build a new modal for users to add decisions.

Next up is to make the modal actually do something. Then show decision issues alongside the request issues.

![screen shot 2018-11-26 at 1 31 54 pm](https://user-images.githubusercontent.com/3885236/49034340-b5eaba80-f17f-11e8-8838-646c1b16228b.png)

![screen shot 2018-11-26 at 1 33 19 pm](https://user-images.githubusercontent.com/3885236/49034399-e4689580-f17f-11e8-8d94-89d7ae9f3c3c.png)

### Testing Plan
1. Existing tests pass when feature toggle is off.
@mdbenjam mdbenjam mentioned this issue Nov 28, 2018
Merged
va-bot pushed a commit that referenced this issue Nov 28, 2018
@mdbenjam
Show decision issues (#8003)
adc1648 
Connects: #7966, Resolves: #7965, Resolves: #7957, Resolves: #7958

### Description
This change actually makes the add/edit decision issue modal functional. It saves results to the redux store and sends them to the server on completing the flow. It also updates the remand reason select screen to work with these new decision issues.

It also displays decision issues on the case details and disposition selection screen.

### Testing Plan
1. Don't break existing functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdbenjam mdbenjam

@allyceh allyceh

Labels
Feature: case-details Feature: caseflow-decisions Team: Foxtrot 🦊
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdbenjam @lpciferri @allyceh