Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create add decisions page with request issues + decision issues #7965

Closed
lpciferri opened this issue Nov 21, 2018 · 2 comments
Closed

Create add decisions page with request issues + decision issues #7965

lpciferri opened this issue Nov 21, 2018 · 2 comments
Assignees
@anyakhvost @allyceh
Labels
Feature: caseflow-decisions Team: Foxtrot 🦊

Comments

@lpciferri
Copy link
Contributor

lpciferri commented Nov 21, 2018 •
edited by anyakhvost

Part of Editing AMA issues

After an attorney has added decision issues in the modal, we should display them back on the Add decisions page in the checkout flow.

AC

  • Users can see both request issues and the decision issues they are connected to in the Add decisions page
  • All decision issues also display a disposition (allowed, remanded, etc.)
  • If the user adds one decision to many request issues, display the decision under all issues to which it's added. Also display a link icon + "Added to # issues" in each instance of the decision.
  • When the user tries to "Continue" without adding a decision, display an error message.
  • When the benefit type on the decision issue differs from the benefit type on the request issue, display the update benefit type to the user for reference. Example: Request issue is Compensation, and user adds an Education decision issue. Display "Education" in decision issue.
    • If the benefit type on decision issue does not differ from the benefit type on the request issue, don't don't display benefit type in the decision issue. (Note: This will be the case 99% of the time.)

Mocks

Latest updates:

  • Added diagnostic code field to each request and decision issue
  • Added Delete button to the left of Edit button to delete the decision issue

image
@lpciferri lpciferri mentioned this issue Nov 21, 2018
Closed
@mdbenjam mdbenjam mentioned this issue Nov 26, 2018
Merged
va-bot pushed a commit that referenced this issue Nov 27, 2018
@mdbenjam
Issue editing frontend (#7962)
f63a078 
Connects: #7957, Connects: #7958, Connects: #7965

### Description
This PR begins adding the editing issue frontend.

1) Update the case details page to show the new AMA issue style.
2) Create a new select disposition page (screenshot below).
3) Build a new modal for users to add decisions.

Next up is to make the modal actually do something. Then show decision issues alongside the request issues.

![screen shot 2018-11-26 at 1 31 54 pm](https://user-images.githubusercontent.com/3885236/49034340-b5eaba80-f17f-11e8-8838-646c1b16228b.png)

![screen shot 2018-11-26 at 1 33 19 pm](https://user-images.githubusercontent.com/3885236/49034399-e4689580-f17f-11e8-8d94-89d7ae9f3c3c.png)

### Testing Plan
1. Existing tests pass when feature toggle is off.
@mdbenjam mdbenjam mentioned this issue Nov 28, 2018
Merged
va-bot pushed a commit that referenced this issue Nov 28, 2018
@mdbenjam
Show decision issues (#8003)
adc1648 
Connects: #7966, Resolves: #7965, Resolves: #7957, Resolves: #7958

### Description
This change actually makes the add/edit decision issue modal functional. It saves results to the redux store and sends them to the server on completing the flow. It also updates the remand reason select screen to work with these new decision issues.

It also displays decision issues on the case details and disposition selection screen.

### Testing Plan
1. Don't break existing functionality
@allyceh allyceh mentioned this issue Dec 10, 2018
Closed
12 tasks
@allyceh allyceh reopened this Dec 19, 2018
@allyceh
Copy link
Contributor

allyceh commented Dec 19, 2018

@mdbenjam @aroltsch Re-opened and updated AC + mock.

@mdbenjam mdbenjam mentioned this issue Dec 20, 2018
Merged
va-bot pushed a commit that referenced this issue Dec 21, 2018
@mdbenjam
UI for multiple request issue <-> single decision issue (#8181)
53dc4c0 
Resolves: #8175 Connects: #7965

### Description
A couple changes in this PR.

1) Copy changes
2) Adding UI to connect multiple request issues to a single decision issue.
3) Better testing for the decision issue flow
@anyakhvost anyakhvost assigned anyakhvost and unassigned mdbenjam Jan 2, 2019
@allyceh allyceh mentioned this issue Jan 16, 2019
Closed
@anyakhvost
Copy link
Contributor

Opened a new ticket

@ghost ghost removed the Current-Sprint label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anyakhvost anyakhvost

@allyceh allyceh

Labels
Feature: caseflow-decisions Team: Foxtrot 🦊
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anyakhvost @mdbenjam @lpciferri @allyceh