Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End holds set with timed hold tasks #10687

Merged
merged 18 commits into from
May 10, 2019
Merged

End holds set with timed hold tasks #10687

merged 18 commits into from
May 10, 2019

Commits on May 8, 2019

  1. Connect tasks with related timed hold tasks

    @lowellrex
    lowellrex authored and Tomas Apodaca committed May 8, 2019
    Configuration menu
    Copy the full SHA
    21d4afe View commit details
    Browse the repository at this point in the history

  2. test coverage

    Tomas Apodaca committed May 8, 2019
    Configuration menu
    Copy the full SHA
    2fb2c08 View commit details
    Browse the repository at this point in the history

  3. move task action funcs into new repository object 

    Freeing up space in models/task.rb which had gone over its line limit.
Also removed timeline_details method from models/task.rb which was no
longer being used.
    Tomas Apodaca committed May 8, 2019
    Configuration menu
    Copy the full SHA
    2f6a333 View commit details
    Browse the repository at this point in the history

  4. fix modal and add more tests 

    Also, hide TimedHoldTasks from the queue table view.
    Tomas Apodaca committed May 8, 2019
    Configuration menu
    Copy the full SHA
    0baf7d0 View commit details
    Browse the repository at this point in the history

  5. close timed hold tasks when parents are updated

    Tomas Apodaca committed May 8, 2019
    Configuration menu
    Copy the full SHA
    42012c9 View commit details
    Browse the repository at this point in the history

  6. validate only one task timer per timed hold task

    Tomas Apodaca committed May 8, 2019
    Configuration menu
    Copy the full SHA
    78ff311 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/master' into lowell/9207_end_tim… 

    …ed_hold
    Tomas Apodaca committed May 8, 2019
    Configuration menu
    Copy the full SHA
    35402df View commit details
    Browse the repository at this point in the history

Commits on May 9, 2019

  1. cancel timed hold task when parent updated 

    Not just when parent's status is updated, but when any parameter of the
parent (aside from placed_on_hold_at) is updated.
    Tomas Apodaca committed May 9, 2019
    Configuration menu
    Copy the full SHA
    7946f18 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into lowell/9207_end_tim… 

    …ed_hold
    Tomas Apodaca committed May 9, 2019
    Configuration menu
    Copy the full SHA
    55089f2 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into lowell/9207_end_tim… 

    …ed_hold
    Tomas Apodaca committed May 9, 2019
    Configuration menu
    Copy the full SHA
    4a9eeba View commit details
    Browse the repository at this point in the history

  4. validate creating a child task cancels timed hold

    Tomas Apodaca committed May 9, 2019
    Configuration menu
    Copy the full SHA
    2edb095 View commit details
    Browse the repository at this point in the history

  5. revert task timer validation 

    We may revisit this idea later, possibly as a validation on the
TaskTimer object instead of the TimedHoldTask, due to the way in
which TaskTimers are instantiated via the concern.
    Tomas Apodaca committed May 9, 2019
    Configuration menu
    Copy the full SHA
    5036629 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into lowell/9207_end_tim… 

    …ed_hold
    Tomas Apodaca committed May 9, 2019
    Configuration menu
    Copy the full SHA
    e8ac307 View commit details
    Browse the repository at this point in the history

  7. use more communicative variable name

    Tomas Apodaca committed May 9, 2019
    Configuration menu
    Copy the full SHA
    c3074d8 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into lowell/9207_end_timed_hold

    va-bot authored May 9, 2019
    Configuration menu
    Copy the full SHA
    454d539 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. Merge branch 'master' into lowell/9207_end_timed_hold

    va-bot authored May 10, 2019
    Configuration menu
    Copy the full SHA
    dde776a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into lowell/9207_end_timed_hold

    va-bot authored May 10, 2019
    Configuration menu
    Copy the full SHA
    fa79cca View commit details
    Browse the repository at this point in the history

  3. improve end hold controller code coverage

    Tomas Apodaca committed May 10, 2019
    Configuration menu
    Copy the full SHA
    71df9b7 View commit details
    Browse the repository at this point in the history