Don't automatically require rails_helper #11352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Code Climate has analyzed commit fbc7ec1 and detected 0 issues on this pull request. View more on Code Climate. |
monfresh
force-pushed
the
mb-rails-helper
branch
from
0a10bd5
to
fa9b386
Compare
**Why**: Our "rails_helper" file contains a lot of intensive work that heavily slows down tests. By automatically requiring this file in `.rspec`, it unnecessarily slows down tests that don't need it. As an example, none of our specs in `mappers` require `rails_helper`. When we run specs the old way, the specs run in 16.77 seconds. When we stop requiring `rails_helper`, they run in 0.03745 seconds. That's 448x faster! The recommended best practice is to only require `rails_helper` when it is needed. The next step is to break down the different parts of `rails_helper` into separate files in `spec/support` so that we can further speed up tests. For example, some of the setup in `rails_helper` only applies to feature specs.
monfresh
force-pushed
the
mb-rails-helper
branch
from
fa9b386
to
d05b933
Compare
pkarman
approved these changes
Jul 10, 2019
|
I don't think it's related. The specs passed earlier. Danger is complaining because |
monfresh
added
the
Ready-to-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Our "rails_helper" file contains a lot of intensive work that
heavily slows down tests. By automatically requiring this file in
.rspec, it unnecessarily slows down tests that don't need it.As an example, none of our specs in
mappersrequirerails_helper.When we run specs the old way, the specs run in 16.77 seconds. When we
stop requiring
rails_helper, they run in 0.03745 seconds. That's448x faster!
The recommended best practice is to only require
rails_helperwhenit is needed. The next step is to break down the different parts of
rails_helperinto separate files inspec/supportso that we canfurther speed up tests. For example, some of the setup in
rails_helperonly applies to feature specs.