Speed up test suite #11470
Merged
Speed up test suite #11470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Code Climate has analyzed commit f2d7017 and detected 0 issues on this pull request. View more on Code Climate. |
monfresh
force-pushed
the
mb-rails-helper
branch
from
fe8e357
to
fdfad9a
Compare
monfresh
changed the title
monfresh
force-pushed
the
mb-rails-helper
branch
15 times, most recently
from
c034422
to
6dd448a
Compare
monfresh
commented
Jul 26, 2019
| - run: | ||
| name: RSpec | ||
| command: | | ||
| mkdir -p ~/test-results/rspec | ||
| testfiles=$(circleci tests glob "spec/**/*spec.rb" | circleci tests split --split-by timings) | ||
| testfiles=$(circleci tests glob "spec/**/*spec.rb" | circleci tests split --split-by=timings) |
There was a problem hiding this comment.
I'm not sure if this makes a difference, but the documentation includes the = sign.
anyakhvost
reviewed
Jul 29, 2019
| require "rails_helper" | ||
|
|
||
| RSpec.describe Api::V2::HearingsController, type: :controller do | ||
| RSpec.describe Api::V2::HearingsController, :vacols, type: :controller do |
There was a problem hiding this comment.
I know it is a lot to change but I would rename it to be postgres_and_vacols to make it more clear
anyakhvost
approved these changes
Jul 29, 2019
**How**: Our biggest bottleneck in specs is the VACOLS-related DB cleaning in `database_cleaner.rb`. Since only specific tests need to interact with VACOLS, it makes sense to only perform the DB cleaning for those tests. - Create separate `database_cleaner` and `vacols_database_cleaner` files that only clean the Postgres and Oracle DB, respectively. - Don't automatically require these 2 files in `rails_helper`. Instead, require one or the other as needed in each spec. - When the entire suite is run, once it encounters a `require` statement to load `database_cleaner` or `vacols_database_cleaner`, it will run the DB cleaning in both files for all subsequent tests. To avoid that, we additionally specify that the Postgres cleaning should only happen in specs that are tagged with `:postgres`, and the Oracle cleaning in tests tagged with `:vacols`. - Move the loading of the `Vftypes`, `Issref`, and `Actcode` VACOLS tables out of a `before(:all)` block and into a separate rake task since this only needs to run once for the lifetime of the test DB. We don't want to put it in a `before(:suite)` block because that will slow down running individual tests locally. - Move other helper methods out of `rails_helper` into separate files for better organization
monfresh
force-pushed
the
mb-rails-helper
branch
from
d816bdf
to
550b2c9
Compare
monfresh
added
the
Ready-to-Merge
monfresh
added a commit
that referenced
this pull request
Jul 30, 2019
**Why**: In #11470, we moved the one-time VACOLS setup from a `before(:all)` block into a separate rake task that runs in Circle CI before the test suite is run. This PR allows that setup to happen locally for people setting up the repo for the first time, or those who might have run `make clean`, which destroys the VACOLS DBs before creating them again.
va-bot
pushed a commit
that referenced
this pull request
Jul 30, 2019
**Why**: In #11470, we moved the one-time VACOLS setup from a `before(:all)` block into a separate rake task that runs in Circle CI before the test suite is run. This PR allows that setup to happen locally for people setting up the repo for the first time, or those who might have run `make clean`, which destroys the VACOLS DBs before creating them again.
7 tasks
This was referenced Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How: Our biggest bottleneck in specs is the VACOLS-related DB
cleaning in
database_cleaner.rb. Since only specific tests need tointeract with VACOLS, it makes sense to only perform the DB cleaning
for those tests.
database_cleanerandvacols_database_cleanerfiles that only clean the Postgres or both Postgres and Oracle DB, respectively.
rails_helper. Instead,require one or the other as needed in each spec.
requirestatementto load
database_cleanerorvacols_database_cleaner, it will run theDB cleaning in both files for all subsequent tests. To avoid that, we
additionally specify that the Postgres cleaning should only happen in
specs that are tagged with
:postgres, and the Oracle cleaning in teststagged with
:vacols.Vftypes,Issref, andActcodeVACOLStables out of a
before(:all)block and into a separate rake tasksince this only needs to run once for the lifetime of the test DB. We
don't want to put it in a
before(:suite)block because that will slowdown running individual tests locally.
rails_helperinto separate filesfor better organization
These changes result in significant time savings locally. I tested with all non-feature specs:
Before these changes, those tests ran in about 18 minutes. After the changes, they run in about 6.5 minutes! The difference in Circle CI, where we have parallelization, is not as drastic, and I'm not sure why.