Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow judges to correct issues for hearings they were assigned to #11680

Merged
merged 10 commits into from
Aug 8, 2019
Merged

Allow judges to correct issues for hearings they were assigned to #11680

merged 10 commits into from
Aug 8, 2019

Conversation

ferristseng
Copy link
Contributor

@ferristseng ferristseng commented Aug 6, 2019 •
edited

Resolves #10562

Description

  • Modify appeal request issues policy to allow the assigned judge to edit issues
  • Feature is behind :allow_judge_edit_issues feature toggle
  • Fix issue in test that was failing because there was an ambiguous sort order

@codeclimate
Copy link

codeclimate bot commented Aug 6, 2019 •
edited

Code Climate has analyzed commit 2e44935 and detected 0 issues on this pull request.

View more on Code Climate.

@ferristseng ferristseng marked this pull request as ready for review August 7, 2019 18:26
tomas-nava
tomas-nava approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@tomas-nava tomas-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩approve!

Left one non-blocking suggestion for a change in the tests.

spec/feature/queue/case_details/edit_issues_spec.rb Show resolved Hide resolved
@ferristseng @tomas-nava
Update spec/feature/queue/case_details/edit_issues_spec.rb
62a498a 
Co-Authored-By: Tomas Apodaca <45415133+tomas-nava@users.noreply.github.com>
@ferristseng ferristseng added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Aug 7, 2019
@va-bot va-bot merged commit cddd5d7 into master Aug 8, 2019
@va-bot va-bot deleted the ftseng-correct-issues-case-details branch August 8, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-nava tomas-nava tomas-nava approved these changes

Assignees
No one assigned
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow judges to "Correct Issues" from Case Details when they are assigned a hearing
3 participants
@ferristseng @tomas-nava @va-bot