[PART 1] Create a "priority only" distribution #14691
Conversation
Generated by 🚫 Danger |
|
Code Climate has analyzed commit 463d33c and detected 13 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
…lhorn/14604-priority-only-distribution
hschallhorn
changed the title
| @@ -59,7 +75,7 @@ def ama_distribution | |||
|
|
|||
| def ama_statistics | |||
| { | |||
| batch_size: batch_size, | |||
| batch_size: priority_push? ? @appeals.count : batch_size, | |||
There was a problem hiding this comment.
priority push does not work off of batch size, it either distributes without limit or distributes the provided limit.
| if genpop == "any" | ||
| appeals_to_reject = appeals.flatten.sort_by(&:ready_for_distribution_at).drop(limit) | ||
| appeals = [appeals.first - appeals_to_reject, appeals.last - appeals_to_reject] | ||
| end |
There was a problem hiding this comment.
Found a bug! Detailed here
| expect(distribution.distributed_cases.length).to eq(1) | ||
| expect(distribution_judge.reload.tasks.map(&:appeal)).to match_array([not_tied]) | ||
| end | ||
| end |
There was a problem hiding this comment.
Test for this bug fix
| @@ -324,7 +324,8 @@ def self.distribute_priority_appeals(judge, genpop, limit, dry_run = false) | |||
| judge.vacols_attorney_id, | |||
| (genpop == "any" || genpop == "not_genpop") ? 1 : 0, | |||
| (genpop == "any" || genpop == "only_genpop") ? 1 : 0, | |||
| limit | |||
| limit, | |||
| limit.nil? ? 1 : 0 | |||
There was a problem hiding this comment.
Allows nil limit to be passed to distribute_priority_appeals, indicating that any and all cases should be distributed
| end | ||
| end | ||
|
|
||
| def distribute! | ||
| def distribute!(limit = nil) |
There was a problem hiding this comment.
Allows us to stipulate a limit for priority push cases, when we get to the "aim to hit priority target" portion of the job
…//github.com/department-of-veterans-affairs/caseflow into hschallhorn/14604-priority-only-distribution
| @@ -30,77 +30,6 @@ | |||
| end | |||
|
|
|||
| context "#distribute!" do | |||
| subject { Distribution.create!(judge: judge) } | |||
| bfac: "1", | ||
| bfmpro: "ACT", | ||
| bfcurloc: "81", | ||
| bfdloout: i.months.ago, |
There was a problem hiding this comment.
bfdloout represents how long the case case been ready to distribute. The last one created will be the oldest case.
| :advanced_on_docket_due_to_age, | ||
| :ready_for_distribution, | ||
| docket_type: Constants.AMA_DOCKETS.hearing) | ||
| appeal.tasks.find_by(type: DistributionTask.name).update(assigned_at: i.months.ago) |
There was a problem hiding this comment.
DistributionTask.assigned at represents how long the case case been ready to distribute. The last one created will be the oldest case.
| context "when there is no limit specified" do | ||
| it "distributes all priority cases associated with the judge" do | ||
| distributed_case_ids = priority_legacy_hearings_tied_to_judge.map(&:folder_nr) | ||
| .concat(priority_ama_hearings_tied_to_judge.map(&:uuid)) |
There was a problem hiding this comment.
We should only distribute priority cases tied to the judge
| other_priority_ama_hearings.last.uuid, | ||
| priority_direct_review_cases.last.uuid, | ||
| evidence_submission_cases.last.uuid | ||
| ] |
There was a problem hiding this comment.
We should distribute the 4 oldest cases, regardless of what docket they are from.
| @@ -1,6 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module AmaCaseDistribution | |||
| module AutomaticCaseDistribution | |||
There was a problem hiding this comment.
Sneaky rename to more accurately describe the module
| end | ||
| end | ||
|
|
||
| def requested_distribution |
There was a problem hiding this comment.
Sneaky rename to more accurately describe the method
Bumps #14604
Description
Please explain the changes you made here.
Acceptance Criteria