Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the only_open_task_of_type validation to AttorneyTask and JudgeDecisionReviewTask #16586
Expand the only_open_task_of_type validation to AttorneyTask and JudgeDecisionReviewTask #16586
Changes from 11 commits
bb875f5
2e11eb4
a0e6eff
2dfbe30
947c08b
90ca288
bc92b17
17976e1
fb33495
43fc305
ef27df7
5716194
0957ccc
1b4a087
c7a88d0
3cb33e9
3fc0fb9
9c07fb9
e7288b3
3561be1
d9f31c3
f2d9ea0
f57d474
642e963
6859a0a
31ecbbf
b2f0763
8ee4a22
2a0d120
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This felt odd even as I typed it, but it was necessary to maintain the docket switch flow. Maybe we should check with the board that we want to allow multiple
DocketSwitchDeniedTask
andDocketSwitchGrantedTask
instances for one appeal?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eileen-nava Yes, check with Foxtrot and @araposo-tistatech first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ann-Marie directed me to Foxtrot. Slack response from Yang:
Yang also noted that @jcq created this task tree structure. I'll check with JC about this when he is back from PTO.
For now, overriding the validation seems fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.